Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing f prefix on f-strings fix #2826

Merged

Conversation

code-review-doctor
Copy link
Contributor

Fixes #2825

@fubuloubu fubuloubu enabled auto-merge (squash) April 25, 2022 09:40
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2022

Codecov Report

Merging #2826 (2e0e618) into master (48e326f) will decrease coverage by 0.75%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #2826      +/-   ##
==========================================
- Coverage   87.36%   86.60%   -0.76%     
==========================================
  Files          94       94              
  Lines       10037    10037              
  Branches     2486     2486              
==========================================
- Hits         8769     8693      -76     
- Misses        802      865      +63     
- Partials      466      479      +13     
Impacted Files Coverage Δ
vyper/builtin_functions/convert.py 88.21% <0.00%> (-2.29%) ⬇️
vyper/codegen/abi_encoder.py 86.66% <0.00%> (ø)
vyper/codegen/core.py 84.55% <0.00%> (ø)
vyper/semantics/types/function.py 87.10% <0.00%> (ø)
vyper/builtin_functions/functions.py 84.43% <100.00%> (-4.60%) ⬇️
vyper/__init__.py 58.82% <0.00%> (-17.65%) ⬇️
vyper/semantics/types/value/numeric.py 80.45% <0.00%> (-4.60%) ⬇️
vyper/ast/nodes.py 92.59% <0.00%> (-1.63%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48e326f...2e0e618. Read the comment docs.

vyper/codegen/core.py Outdated Show resolved Hide resolved
@fubuloubu fubuloubu merged commit 8083a78 into vyperlang:master Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing f prefix on f-strings
4 participants