fix some unapplied optimizations #2944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the changed optimizations were getting rolled back, because `_deep_contains` does not work on deconstructed IRnodes
Codecov Report
@@ Coverage Diff @@
## master #2944 +/- ##
==========================================
- Coverage 88.09% 87.99% -0.11%
==========================================
Files 97 97
Lines 10852 10877 +25
Branches 2574 2574
==========================================
+ Hits 9560 9571 +11
- Misses 832 849 +17
+ Partials 460 457 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. |
fixes an optimization regression because `unique_symbols` breaks the merge_calldataload optimization fixes a missed case in merge_calldataload and merge_memzero where the optimization would not get applied if the mstores were the last items in the `seq` block.
|
This pull request introduces 2 alerts when merging 79c668e into c27f225 - view on LGTM.com new alerts:
|
fubuloubu
approved these changes
Jul 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the changed optimizations were getting rolled back, because
_deep_containsdoes not work on deconstructed IRnodesalso fixes #2943
What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture