-
-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automatic versioning #312
Conversation
@@ -1,5 +1,13 @@ | |||
[bumpversion] | |||
current_version = 0.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should Viper start from 0.1 or 0.0.1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.1.0 would be when features are solidified and ready for the first beta IMO.
I would start at 0.0.1 for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Viper is ready to use right now, not in production environment but if in test environment. So, VIper has solid features :) At least compile a whole contract.
But it's ok start from 0.0.1 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure agreed, but there are unimplemented features that I would argue need to be there for a complete first draft to alpha/beta with. Perhaps that is more conservative than necessary, but that's my opinion.
I'm not in any position to be dictating what the first version is here anyways since that still needs to be set up initially after this PR is merged, and that's not up to me haha. I just used 0.0.1 because that is what it was.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hahaha, agree .. Well, maybe @vbuterin could tell you what is the right version for now.
But the PR is OK. : +1:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
After this pull request is accepted, create a new tag with
bumpversion