-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix[lang]: fix importing of flag types #3871
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3871 +/- ##
==========================================
+ Coverage 86.33% 86.38% +0.04%
==========================================
Files 92 92
Lines 14010 14017 +7
Branches 3077 3079 +2
==========================================
+ Hits 12096 12108 +12
+ Misses 1484 1480 -4
+ Partials 430 429 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
fix imports for flag types. this is a missed case from 8ccacb3. this commit adds flags into the module data and threads them through codegen. --------- Co-authored-by: Charles Cooper <cooper.charles.m@gmail.com>
What I did
flag
types not properly imported via modules #3827How I did it
How to verify it
test_flag_imports.py
Commit message
Description for the changelog
Cute Animal Picture