feat[ir]: return IRnode from context.new_variable()
#3905
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this unifies various functions which modify global settings: anchor_opt_level, anchor_evm_version, _set_debug
small refactor: refactor replicated code for variable deallocatoin
it better belongs in a separate pass
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| def set_global_settings(new_settings: Optional[Settings]) -> None: | ||
| assert isinstance(new_settings, Settings) or new_settings is None | ||
| # TODO evil circular import | ||
| from vyper.evm.opcodes import DEFAULT_EVM_VERSION, EVM_VERSIONS, set_global_evm_version |
Check notice
Code scanning / CodeQL
Cyclic import Note
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3905 +/- ##
==========================================
- Coverage 90.92% 89.14% -1.78%
==========================================
Files 95 95
Lines 14387 14414 +27
Branches 3186 3189 +3
==========================================
- Hits 13081 12849 -232
- Misses 904 1110 +206
- Partials 402 455 +53 ☔ View full report in Codecov by Sentry. |
|
superseded by #3941 (these commits were incorporated there) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
per title, return IRnode from context.new_variable(). additionally, when experimental_codegen is enabled, return an abstract "alloca" object instead of an int. this allows us to treat allocated memory as abstract, which will enable mem2stack and related optimizations.
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture