refactor[codegen]: make settings into a global object #3929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this unifies various functions which modify global settings: anchor_opt_level, anchor_evm_version, _set_debug
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3929 +/- ##
==========================================
- Coverage 90.96% 90.75% -0.21%
==========================================
Files 95 95
Lines 14397 14393 -4
Branches 3191 3190 -1
==========================================
- Hits 13096 13063 -33
- Misses 901 924 +23
- Partials 400 406 +6 ☔ View full report in Codecov by Sentry. |
harkal
approved these changes
Apr 10, 2024
fubuloubu
reviewed
Apr 10, 2024
vyper/evm/opcodes.py
Outdated
| @@ -208,16 +207,9 @@ | |||
| IR_OPCODES: OpcodeMap = {**OPCODES, **PSEUDO_OPCODES} | |||
|
|
|||
|
|
|||
| @contextlib.contextmanager | |||
| def anchor_evm_version(evm_version: Optional[str] = None) -> Generator: | |||
| def set_global_evm_version(evm_version: int) -> None: | |||
| global active_evm_version | |||
There was a problem hiding this comment.
Can this be combined into the global settings singleton?
There was a problem hiding this comment.
i think the change is a bit more extensive, but let me try
electriclilies
pushed a commit
to electriclilies/vyper
that referenced
this pull request
Apr 27, 2024
this commit adds a global settings object, unifying various functions which modify global settings: anchor_opt_level, anchor_evm_version, _set_debug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
cherry-picked relevant commits from #3905
How to verify it
Commit message
Description for the changelog
Cute Animal Picture