fix[venom]: add unique_symbols check to venom pipeline
#4149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when `-Onone` is specified along with `--experimental-codegen`, the unique symbols check does not get run. this calculates the `ir_node.unique_symbols` property, which implicitly runs the unique symbols check.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4149 +/- ##
==========================================
- Coverage 91.32% 90.35% -0.97%
==========================================
Files 109 109
Lines 15569 15555 -14
Branches 3418 3415 -3
==========================================
- Hits 14218 14055 -163
- Misses 923 1040 +117
- Partials 428 460 +32 ☔ View full report in Codecov by Sentry. |
charles-cooper
changed the title
unique_symbols check to venom pipeline
fubuloubu
approved these changes
Jun 17, 2024
| @@ -114,6 +114,8 @@ | |||
|
|
|||
| # convert IRnode directly to venom | |||
| def ir_node_to_venom(ir: IRnode) -> IRContext: | |||
| _ = ir.unique_symbols # run unique symbols check | |||
There was a problem hiding this comment.
This seems rather strange at a quick glance
There was a problem hiding this comment.
unique_symbols performs a sanity check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
fix #4072
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture