Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix[venom]: add unique_symbols check to venom pipeline #4149

Merged
merged 3 commits into from
Jun 17, 2024
Merged

fix[venom]: add unique_symbols check to venom pipeline #4149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bbb89df
add unique symbols check to venom pipeline
charles-cooper Jun 14, 2024
710a3f8
Merge branch 'master' into fix/venom-unique-symbols
charles-cooper Jun 17, 2024
dfe0040
change an assertion to a proper exception
charles-cooper Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion vyper/codegen/ir_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,8 @@ def unique_symbols(self):
for arg in children:
s = arg.unique_symbols
non_uniques = ret.intersection(s)
assert len(non_uniques) == 0, f"non-unique symbols {non_uniques}"
if len(non_uniques) != 0: # pragma: nocover
raise CompilerPanic(f"non-unique symbols {non_uniques}")
ret |= s
return ret

Expand Down
2 changes: 2 additions & 0 deletions vyper/venom/ir_node_to_venom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,8 @@

# convert IRnode directly to venom
def ir_node_to_venom(ir: IRnode) -> IRContext:
_ = ir.unique_symbols # run unique symbols check
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems rather strange at a quick glance

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unique_symbols performs a sanity check


global _global_symbols, _external_functions
_global_symbols = {}
_external_functions = {}
Expand Down
Loading