New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permission names #21
Comments
Hello, I think you should propose this feature request to spatie/laravel-permission, if they will add this, we will definitely include it in this library. |
Without extending the package, you could add a layer that uses the |
@drbyte in some projects I also create a display_name column in permissions and roles tables for such purposes. If Spatie will add it, it would be awesome |
It's being considered for v3, but nothing confirmed yet. |
May be create own table for this and add hasOne relation? Or make your own migration for spatie permissions table, with adding title column. I think we can long wait for Spatie, if they coding v3. |
I have a solution for now. In Text::make(__('nova-permission-tool::permissions.name'), 'name')
// ...
->displayUsing(function ($value) {
return __('nova-permission-tool::permissions.names.' . $value);
}), In project's <?php
return [
'name' => 'Name',
'guard_name' => 'Guard Name',
'created_at' => 'Created at',
'updated_at' => 'Updated at',
'names' => [
'users-create' => 'Create Users',
],
]; Which will lead to this: The same implementation can be applied for roles. If Spatie adds translatable option for permission and role names we will switch to it. |
I think it well be more useful if use two different columns. One for Users, second for Developers, they can check permissions keys with this page. |
We can make a computed field then. |
Then it looks great! Thanks Bro! |
Just tagged v1.2.0. Check it out. You need to create in |
Today i use this future, all good and work! For other coders: in lang file you need use |
The existing |
When translation key `display_names` has been set in the `resources\lang\vendor\nova-permission-tool\en\permissions.php` it show the translation only in the Permission index page. This Pr aim to show the translation also when adding/editing/showing Role's permission. This is more consistant with vyuldashev#21 (comment)
Thanks, good nova module!
I see one trouble with it. If i want give readable names for permissions, i have long names in my code. And If i want give short names for better code - swears editor, because he not understand some things. Situation is aggravated when the Manager does not know english permissions names.
Maybe add a column "title" to display in the interface and a column "name" to use in the code?
The text was updated successfully, but these errors were encountered: