Translate the permission role relationship according to the display_name #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When translation key `display_names` has been set in the `resources\lang\vendor\nova-permission-tool\en\permissions.php` it show the translation only in the Permission index page. This Pr aim to show the translation also when adding/editing/showing Role's permission. This is more consistant with vyuldashev#21 (comment)
meyer59
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When translation key
display_nameshas been set in theresources\lang\vendor\nova-permission-tool\en\permissions.phpit show the translation only in the Permission index page. This Pr aim to show the translation also when adding/editing/showing Role's permission. This is more consistant with #21 (comment)