Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pull HashingListSubtract into (new) high-level util package, from sylabs 1562 #286

Merged
merged 1 commit into from
Apr 25, 2023
Merged

pull HashingListSubtract into (new) high-level util package, from sylabs 1562 #286

merged 1 commit into from
Apr 25, 2023

Conversation

edytuk
Copy link
Collaborator

@edytuk edytuk commented Apr 24, 2023

This pulls in sylabs PR

  • sylabs/singularity# 1562
    which fixed
  • sylabs/singularity# 1485

The original PR description was:

Now that we can safely assume Go 1.18+ (see here), I have moved a lo-based utility function (HashingListSubtract()) that was buried inside the test code into a more general-purpose utility package.

@edytuk
pull HashingListSubtract into (new) high-level util package (sylabs/s…
5121d81 
…ingularity#1562)

* pull HashingListSubtract into (new) high-level util package

* to-be-squashed: addressing DT's comments

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
@edytuk edytuk requested a review from DrDaveD April 24, 2023 13:22
@edytuk edytuk merged commit 6242c09 into oci-action Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrDaveD DrDaveD DrDaveD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edytuk @DrDaveD