Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify best practices for retrieval and ownership of data #496

Closed
brownoxford opened this issue Feb 2, 2023 · 8 comments
Closed

Clarify best practices for retrieval and ownership of data #496

brownoxford opened this issue Feb 2, 2023 · 8 comments
Assignees
Labels
ready-for-pr v1.0 Issues that are ready for the v1.0 cut of the spec

Comments

@brownoxford
Copy link
Collaborator

brownoxford commented Feb 2, 2023

Section 8.1.1 of the spec includes the following paragraph:

To assemble a collection of Credentials linked together by a workflow, data may be queried by a combination of TraceablePresentation.workflow.definition and TraceablePresentation.workflow.instance, assuming that the implementation's underlying data store persists presentation metadata upon receipt. Rules for ensuring the retrieval of the most "correct" credentials associated for that workflow instance are covered below in the section on Credentials.

Some discussion and explicit clarification of use of issuer SHOULD be added to the spec text to clarify best practices for retrieval and ownership of data

@nissimsan
Copy link
Collaborator

Add paragraph on what the server and client is expected to retrieve data.

@nissimsan
Copy link
Collaborator

@mprorock , will you please action this.

@OR13
Copy link
Collaborator

OR13 commented Jul 11, 2023

Screen Shot 2023-07-11 at 1 08 37 PM

^ this does not look great... any improvement to this is welcome.

@OR13
Copy link
Collaborator

OR13 commented Aug 22, 2023

Still needs some respec text, and to remove the issue marker.

@nissimsan
Copy link
Collaborator

Looking for volunteers on this.

@nissimsan
Copy link
Collaborator

@brownoxford , I did some work on this part of the respec. Pls re-review which parts of this is still relevant

@brownoxford brownoxford self-assigned this Oct 17, 2023
@mkhraisha mkhraisha added the v1.0 Issues that are ready for the v1.0 cut of the spec label Jan 9, 2024
@brownoxford
Copy link
Collaborator Author

Note, this is now section 9.1.1 in the spec. Also, the paragraph in question has been entirely removed and it appears that details of Workflow are now specified in the trace vocab spec.

@OR13, this issue was originally raised by you, do you still feel that we need to make modifications to the interop spec?

@mkhraisha
Copy link
Collaborator

as discussed on April 11th call, we no longer think this is necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-pr v1.0 Issues that are ready for the v1.0 cut of the spec
Projects
None yet
Development

No branches or pull requests

4 participants