-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Identifier Discovery #258
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment about VC-JWT.
everything else looks great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great
I just copied the text already in the discovery md file... JWK keys can be
used to verify both detached JWS and JWTs. (Most LD proofs use detached
JWS).
…On Tue, Jun 28, 2022, 7:24 AM Mahmoud Alkhraishi ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In docs/sections/use-case-requirements.html
<#258 (comment)>
:
> +</section>
+
+ <p>
+ The <code>didDocument</code> MAY contain a <code>verificationMethod</code> section,
+ which MAY be used to support <code>did:web</code> based verification relationships.
+ </p>
+<p>
+ The <code>didDocument</code> MUST NOT contain <code>verificationMethods</code> where the controller is different from the DID Subject.
+</p>
+
+<p>
+ All <code>Ed25519VerificationKey2018</code> types support <code>Ed25519Siganture2018</code>.
+</p>
+
+<p>
+ All <code>JsonWebKey2020</code> types support <code>JsonWebSignature2020</code> AND <code>VC-JWT</code>.
do we need to have AND here?
aren't most implementations of JWS2020 LD-Proof based rather than JWT
based?
—
Reply to this email directly, view it on GitHub
<#258 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB7JLMELVIRZ3JXPFI6P2HTVRLVGNANCNFSM5Z7UVIDA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed that sentence when we inserted the discovery document then.
I'll go ahead and remove my CR
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
convert markdown to respec.