Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address eslint issues in postman tests #58

Merged
merged 2 commits into from
Jan 31, 2022
Merged

fix: address eslint issues in postman tests #58

merged 2 commits into from
Jan 31, 2022

Conversation

brownoxford
Copy link
Collaborator

Address disabled eslint rules from #44.

Note that the eslint-disable-line import/extensions exception when importing the sha256 module is required because the default specifier resolution of "explicit" will not locate the module without the .js extension. An alternative would be to require --experimental-specifier-resolution=node on the command line when running the tests, but that seems like an unnecessary barrier to testing.

Copy link
Collaborator

@mkhraisha mkhraisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a specific reason we switched out from using async/await to .then?

packages/tests-postman/index.js Outdated Show resolved Hide resolved
@brownoxford
Copy link
Collaborator Author

is there a specific reason we switched out from using async/await to .then?

These were refactored to comply with the new eslint rules. Using await inside of a loop violates Disallow await inside of loops (no-await-in-loop)

@brownoxford brownoxford requested a review from OR13 January 27, 2022 14:08
@OR13 OR13 merged commit 5493377 into w3c-ccg:main Jan 31, 2022
@brownoxford brownoxford deleted the refactor/eslint-fixes branch February 1, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants