-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VerifiablePresentationResponse with property verifiablePresentation #314
Merged
msporny
merged 12 commits into
w3c-ccg:main
from
aljones15:exchange-transaction-should-have-verifiablePresentation
Oct 28, 2022
Merged
Add VerifiablePresentationResponse with property verifiablePresentation #314
msporny
merged 12 commits into
w3c-ccg:main
from
aljones15:exchange-transaction-should-have-verifiablePresentation
Oct 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallTed
reviewed
Oct 26, 2022
My reviews are of limited value. You should re-request the reviews from @msporny, @peacekeeper, @mavarley, and @mkhraisha. |
your review was valuable, but I don't have the ability to request more reviewers. Anyways, thanks for your comments. |
msporny
approved these changes
Oct 28, 2022
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
65fa21a
to
9f34a10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Responses from the continue endpoint should be VPs.
NOTE: This PR began as a simple feature request: add
verifiablePresentation
as property in the request/response for exchange continue. This turned out to be a bigger task than anticipated as it required adding response bodies to responses. This Pr handles that, but refactoring of the underlying code remains andeslint
has also shown issues with therespec-oas.js
reporter that probably need to be addressed in another PR.Addresses: #311
Features:
body
renderJsonSchemaObject
can now handleanyOf
eslint
andeslint-config-digitalbazaar
were added to the project