Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VerifiablePresentationResponse with property verifiablePresentation #314

Conversation

aljones15
Copy link
Contributor

@aljones15 aljones15 commented Oct 20, 2022

Responses from the continue endpoint should be VPs.

NOTE: This PR began as a simple feature request: add verifiablePresentation as property in the request/response for exchange continue. This turned out to be a bigger task than anticipated as it required adding response bodies to responses. This Pr handles that, but refactoring of the underlying code remains and eslint has also shown issues with the respec-oas.js reporter that probably need to be addressed in another PR.

Addresses: #311

20221025_14h19m40s_grim

Features:

  1. The response table now has a new section body
  2. Response bodies are shown as summaries
  3. renderJsonSchemaObject can now handle anyOf
  4. Some functions in the reporter were trimmed and helper functions were created out of existing code
  5. eslint and eslint-config-digitalbazaar were added to the project

@aljones15 aljones15 marked this pull request as ready for review October 26, 2022 01:55
respec-oas.js Outdated Show resolved Hide resolved
@aljones15 aljones15 requested review from TallTed and removed request for msporny, peacekeeper, mavarley and mkhraisha October 26, 2022 17:51
@TallTed
Copy link
Collaborator

TallTed commented Oct 26, 2022

My reviews are of limited value. You should re-request the reviews from @msporny, @peacekeeper, @mavarley, and @mkhraisha.

@aljones15
Copy link
Contributor Author

My reviews are of limited value. You should re-request the reviews from @msporny, @peacekeeper, @mavarley, and @mkhraisha.

your review was valuable, but I don't have the ability to request more reviewers. Anyways, thanks for your comments.

@aljones15 aljones15 changed the title Add VerifiablePresentationResponse with property verifiableCredential Add VerifiablePresentationResponse with property verifiablePresentation Oct 27, 2022
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@aljones15 aljones15 force-pushed the exchange-transaction-should-have-verifiablePresentation branch from 65fa21a to 9f34a10 Compare October 28, 2022 14:25
@msporny msporny merged commit c37438c into w3c-ccg:main Oct 28, 2022
@aljones15 aljones15 deleted the exchange-transaction-should-have-verifiablePresentation branch October 28, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants