Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't export "resolve" #190

Closed
johannhof opened this issue Feb 3, 2023 · 4 comments · Fixed by #191
Closed

Don't export "resolve" #190

johannhof opened this issue Feb 3, 2023 · 4 comments · Fixed by #191

Comments

@johannhof
Copy link
Member

Any spec author who wants to reference https://webidl.spec.whatwg.org/#resolve through [=resolve=] will run into conflicts with this specification, so we should either avoid exporting or specialize the name of this export.

@johannhof
Copy link
Member Author

@mkruisselbrink
Copy link
Collaborator

I'm not sure what's wrong with being explicit when referencing definitions and referring to the other resolve as [=/resolve=]? The whole point of having "for" namespacing is so different specs can define the same terms without conflicts after all...

@mkruisselbrink
Copy link
Collaborator

Also note that you can use the Assume Explicit For if you want bikeshed to interpret [=resolve=] as [=/resolve=] automatically.

@johannhof
Copy link
Member Author

To be clear I'm not saying that this spec is doing anything wrong, I just think that we could be good citizens and provide an ergonomic improvement (besides including the slash I've always had to add a blurb to link-defaults as well, which may just be my lack of understanding) that applies to a lot of specs.

I'm not trying to set a precedent for always avoiding collisions or anything, but in this case it seems reasonable :)

annevk added a commit that referenced this issue Feb 6, 2023
To "resolve a blob URL".

Closes #190.

Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants