Skip to content

Update the exported text for resolve #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 6, 2023
Merged

Update the exported text for resolve #191

merged 3 commits into from
Feb 6, 2023

Conversation

johannhof
Copy link
Member

@johannhof johannhof commented Feb 3, 2023 •
edited by pr-preview bot
Loading

Closes #190

I'll update https://url.spec.whatwg.org/#url-parsing as soon as this PR merges.

Preview | Diff

mkruisselbrink
mkruisselbrink reviewed Feb 3, 2023
View reviewed changes
Copy link
Collaborator

@mkruisselbrink mkruisselbrink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like kind of a unnecessary change, but I suppose it doesn't hurt...

index.bs Outdated
@@ -1558,7 +1558,7 @@ run the following steps:
## Dereferencing Model for blob URLs ## {#requestResponseModel}

<div algorithm="resolveURL">
To <dfn export for="blob URL" lt="resolve">resolve a blob URL</dfn> given a |url| (a [=URL=]), run the following steps:
To <dfn export for="blob URL">resolve a blob URL</dfn> given a |url| (a [=URL=]), run the following steps:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With resolve a blob URL as text, I'd get rid of the for part, as that is redundant now.

@annevk
Copy link
Member

annevk commented Feb 6, 2023 •
edited
Loading

I agree with @mkruisselbrink that this isn't needed. This is what for is for. We'd have to change a whole lot of terms across a whole lot of specifications if we want by this rationale.

Edit: having said that, in this specific case the change does kinda make sense as the concept doesn't really belong to the blob URL concept.

@johannhof
Copy link
Member Author

I agree with @mkruisselbrink that this isn't needed. This is what for is for. We'd have to change a whole lot of terms across a whole lot of specifications if we want by this rationale.

Sure, I agree as well, but #190 (comment)

Edit: having said that, in this specific case the change does kinda make sense as the concept doesn't really belong to the blob URL concept.

Ok, well, I'll remove the for="blob URL" then :)

annevk
annevk reviewed Feb 6, 2023
View reviewed changes
@johannhof @annevk
Update index.bs
e0f1727 
Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
@annevk annevk merged commit 5b9e27e into w3c:main Feb 6, 2023
@johannhof johannhof deleted the resolve-undefined branch February 8, 2023 14:36
@johannhof johannhof mentioned this pull request Feb 8, 2023
Merged
annevk pushed a commit to whatwg/url that referenced this pull request Feb 8, 2023
@johannhof
Editorial: fix reference to resolve a blob URL
78aabbf 
See w3c/FileAPI#191 for context.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkruisselbrink mkruisselbrink mkruisselbrink left review comments

@annevk annevk annevk left review comments

@saschanaz saschanaz saschanaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't export "resolve"
4 participants
@johannhof @annevk @mkruisselbrink @saschanaz