Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow MediaSource, disallow any more extensions #103

Merged
merged 3 commits into from Feb 1, 2019

Conversation

saschanaz
Copy link
Member

@saschanaz saschanaz commented Jun 19, 2018

Closes #100.

Edit: It seems the WebPlat group only allows authorized members. Hmm.


Preview | Diff

@saschanaz
Copy link
Member Author

Can I just mark this as non-substantive to get a review?

@marcoscaceres
Copy link
Member

This is editorial, by the looks of it. So, yeah, go for it @saschanaz.

@saschanaz
Copy link
Member Author

Marked as non substantive for IPR from ash-nazg.

@annevk
Copy link
Member

annevk commented Feb 1, 2019

@tabatkins does Bikeshed's IDL parser miss some functionality? It errors on the IDL here.

@saschanaz
Copy link
Member Author

Woops, it's because object is a keyword. Replaced it by obj.

@annevk annevk merged commit d3341fd into w3c:master Feb 1, 2019
@annevk
Copy link
Member

annevk commented Feb 1, 2019

Thanks @saschanaz! Sorry for the ping @tabatkins, too soon apparently.

@@ -1730,14 +1729,14 @@ and presents methods for <a>blob URL</a> creation and revocation.
<pre class="idl">
[Exposed=(Window,DedicatedWorker,SharedWorker)]
partial interface URL {
static DOMString createObjectURL(Blob blob);
static DOMString createObjectURL((Blob or MediaSource) obj);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this valid? MediaSource is not exposed everywhere URL is.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why wouldn't it be "valid" (for whatever definition of valid you're asking about)? You just won't be able to pass in a MediaSource when in a worker, but that doesn't seem that crazy?

I'm not sure how else we'd be writing this in IDL either, since you can't have two overloads of the same method with different Exposed= values for example (perhaps you could somehow work around it with two separate partial interfaces? But if that is a possible way to get different overloads with different Exposed= values, I'm not sure why it isn't just allowed directly).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure we had this discussion before (likely different people) and decided it ought to work. See also send() in https://xhr.spec.whatwg.org/#interface-xmlhttprequest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants