Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Set this.root to options.root." doesn't really make sense #274

Closed
smaug---- opened this issue Dec 7, 2017 · 2 comments
Closed

"Set this.root to options.root." doesn't really make sense #274

smaug---- opened this issue Dec 7, 2017 · 2 comments
Labels
needs spec

Comments

@smaug----
Copy link

"Set this.root to options.root." doens't really have meaning.
The interface has attribute root, but that is just a getter method.
szager-chromium added a commit that referenced this issue Sep 7, 2018
@szager-chromium
Fix specification of IntersectionObserver.root attribute in constructor
61593f7 
Issue #274
@szager-chromium szager-chromium mentioned this issue Sep 7, 2018
Merged
@szager-chromium
Copy link
Collaborator

Please take a look at the pull request, and let me know if it adequately addresses this.

szager-chromium added a commit that referenced this issue Sep 2, 2020
@szager-chromium
Fix specification of IntersectionObserver.root attribute in constructor
eaea2bf 
Issue #274
@miketaylr
Copy link
Member

It seems like this was addressed in eaea2bf, feel free to re-open @smaug---- if there's more feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs spec
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@miketaylr @szager-chromium @smaug----