Improve.ready and Activate #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, .ready method was waiting for the change of the state of the regisration's active worker without being synchronized with the steps that set the corresponding ServiceWorkerRegistration object's active ServiceWorker object's state. This changes both .ready and Activate such that .ready tries to resolve the ready promise, if pending, and just returns. And Activate resolves pending ready promises after updating active ServiceWorker object's state. Fixes #1011
mfalken
approved these changes
Feb 9, 2018
jakearchibald
requested changes
Feb 9, 2018
docs/index.bs
Outdated
| 1. Return <a>context object</a>'s [=ServiceWorkerContainer/ready promise=]. | ||
| 1. Let |readyPromise| be the [=context object=]'s [=ServiceWorkerContainer/ready promise=]. | ||
| 1. If |readyPromise| is pending, then: | ||
| 1. Let |registration| be the result of running [=Match Service Worker Registration=] with the [=context object=]'s [=ServiceWorkerContainer/service worker client=]'s [=creation URL=]. |
There was a problem hiding this comment.
I don't think we should be running this on the main thread since it's a disk read.
There was a problem hiding this comment.
Right. I made it run in parallel and queue a task to check out the ready promise.
docs/index.bs
Outdated
| 1. For each [=/service worker client=] |client| whose <a>creation URL</a> <a lt="Match Service Worker Registration">matches</a> |registration|'s [=service worker registration/scope url=]: | ||
| 1. Let |matchedClients| be a [=list=] of [=/service worker clients=] whose <a>creation URL</a> <a lt="Match Service Worker Registration">matches</a> |registration|'s [=service worker registration/scope url=]. | ||
| 1. [=list/For each=] |client| of |matchedClients|: | ||
| 1. Let |readyPromise| be |client|'s [=environment settings object/global object=]'s {{ServiceWorkerContainer}} object's [=ServiceWorkerContainer/ready promise=]. |
There was a problem hiding this comment.
I think we need to queue a task on each client to do this.
There was a problem hiding this comment.
In the subsequent step, I queued a task to resolve the ready promise. But I think your point is we should queue a task to get the ready promise itself for each client in this step, right? I made a change to address that point. Please take a look.
jakearchibald
approved these changes
Apr 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, .ready method was waiting for the change of the
state of the regisration's active worker without being synchronized with
the steps that set the corresponding ServiceWorkerRegistration object's
active ServiceWorker object's state.
This changes both .ready and Activate such that .ready tries to resolve
the ready promise, if pending, and just returns. And Activate resolves
pending ready promises after updating active ServiceWorker object's
state.
Fixes #1011
Preview | Diff