-
Notifications
You must be signed in to change notification settings - Fork 316
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Before this change, .ready method was waiting for the change of the state of the regisration's active worker without being synchronized with the steps that set the corresponding ServiceWorkerRegistration object's active ServiceWorker object's state. This changes both .ready and Activate such that .ready tries to resolve the ready promise, if pending, and just returns. And Activate resolves pending ready promises after updating active ServiceWorker object's state. Fixes #1011.
- Loading branch information
Showing
2 changed files
with
24 additions
and
34 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4cc72bd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rolivo this commit is nothing to do with periodic sync. But no, periodic sync is not in development. Spinning up service workers on an interval creates privacy and battery issues.