Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit Collection page sizes somehow? #246

Closed
strugee opened this issue Jul 17, 2017 · 7 comments
Closed

Limit Collection page sizes somehow? #246

strugee opened this issue Jul 17, 2017 · 7 comments

Comments

@strugee
Copy link

strugee commented Jul 17, 2017

On IRC, saranix points out that "4GB inboxes are possible, completely unpaged is allowed, and any page size is allowed, the server can do whatever and the client is just supposed to be able to handle it... I think that's way too open-ended"

It seems like no sane server would ever do this, but maybe we should put something in the spec about it anyway, just in case?

  • saranix proposes allowing the client to dictate max page size
  • I think that perhaps we should just put a warning about this in Security Considerations and tell clients to drop replies on the floor if they're ridiculously big
  • Maybe just mandate a max page size? But that seems too implementation-specific
  • Or maybe we could just put in something vague like "servers MUST take care to choose page sizes that will not overwhelm clients."
@strugee
Copy link
Author

strugee commented Jul 17, 2017

Something similar applies for object recursion - a full object is obviously much bigger than a URL to an object so if the server is too aggressive about recursing through objects, the response size can balloon. We've kind of already raised this in #229 - not sure if we should change that, do something else, etc.

@akuckartz
Copy link

The size of HTML documents also is not limited by the specification. Should it be? I do not think that this would help.

@strugee
Copy link
Author

strugee commented Jul 18, 2017

Yeah, as I said I feel the same. I think we should just put something in security considerations. At the end of the day if you connect to a server that does bad stuff like this there isn't much we can do in the spec itself about that.

@cwebber
Copy link
Collaborator

cwebber commented Jul 19, 2017

Yeah I think it should go in security considerations. I'd be good with that.

@strugee
Copy link
Author

strugee commented Jul 21, 2017

@cwebber want me to do a PR for this one?

@cwebber
Copy link
Collaborator

cwebber commented Jul 25, 2017

Sure! That would be great.

strugee added a commit to strugee/activitypub that referenced this issue Aug 17, 2017
@strugee
Copy link
Author

strugee commented Aug 17, 2017

Forgot about this! But filed #252 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants