Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note recursive objects in Security Considerations #229

Merged
merged 2 commits into from
Jul 25, 2017

Conversation

strugee
Copy link

@strugee strugee commented Jun 17, 2017

As discussed on IRC.

I'm not sure this is the best wording, but it seemed decent, so...

index.html Outdated
<section id="security-recursive-objects">
<h2>Recursive Objects</h2>
<p>
Servers should take care to properly handle recursive ActivityStreams
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be a good idea to open up "properly". What should the implementer do to protect themselves? Or a short example of what could happen if not. At least I'm not sure what I should do to fulfil this paragraph.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaywink perhaps something like:

Servers should set a limit on how deep to recurse while resolving objects, or otherwise specially handle ActivityStreams objects with recursive references.

Does that seem better to you? It's a bit wordy but I feel like we shouldn't imply that setting a recursion limit is the only way to handle this; there are probably more intelligent things you can do

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better as it's a bit more concrete on the problem and how to handle it 👍

@strugee
Copy link
Author

strugee commented Jun 21, 2017

Pushed a new commit with new wording as discussed with @jaywink 👍

@cwebber cwebber merged commit 28424c3 into w3c:gh-pages Jul 25, 2017
@strugee strugee deleted the recursive-objects branch July 25, 2017 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants