Skip to content

Commit

Permalink
Address Incorrect Mark-Up for Test Navigator Landmark (#362)
Browse files Browse the repository at this point in the history
* Remove complementary role from nav; add aria-labelledby association to nav and ol

* Use non-repeating "Test" label for test steps navigation; use "Test Navigation" as signpost heading text.

* Position "Test Navigation" heading as first child in nav.
  • Loading branch information
jkva committed Feb 1, 2022
1 parent 4bbdc17 commit f903e88
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions client/components/TestRun/TestNavigator.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,14 @@ const TestNavigator = ({
<FontAwesomeIcon icon={faAlignLeft} />
</button>
</div>
{show && <h2>Test Navigator</h2>}
</div>
{show && (
<nav role="complementary">
<ol className="test-navigator-list">
<nav aria-label="Test">
<h2 id="test-navigator-heading">Test Navigation</h2>
<ol
aria-labelledby="test-navigator-heading"
className="test-navigator-list"
>
{tests.map(test => {
let resultClassName = 'not-started';
let resultStatus = 'Not Started';
Expand Down

0 comments on commit f903e88

Please sign in to comment.