Ensure Each TestQueueRow Uses a Unique ID-ref. (#370)

* Ensure each TestQueueRow uses a unique idref. * Include Test Plan Run ID in generated row element ID.
w3c · Feb 1, 2022 · 4bbdc17 · 4bbdc17
1 parent cbe86ff
commit 4bbdc17
Showing 1 changed file with 13 additions and 10 deletions.
diff --git a/client/components/TestQueueRow/index.jsx b/client/components/TestQueueRow/index.jsx
@@ -356,6 +356,17 @@ const TestQueueRow = ({
     const { status, results } = evaluateStatusAndResults();
     const nextReportStatus = evaluateNewReportStatus();
 
+    const getRowId = tester =>
+        [
+            'plan',
+            testPlanReport.id,
+            'run',
+            currentUserTestPlanRun.id,
+            'assignee',
+            tester.username,
+            'completed'
+        ].join('-');
+
     return (
         <tr className="test-queue-run-row">
             <th>{renderAssignedUserToTestPlan()}</th>
@@ -392,19 +403,11 @@ const TestQueueRow = ({
                                             // Allows ATs to read the number of
                                             // completed tests when tabbing to this
                                             // link
-                                            aria-describedby={
-                                                `assignee-${tester.username}-` +
-                                                `completed`
-                                            }
+                                            aria-describedby={getRowId(tester)}
                                         >
                                             {tester.username}
                                         </a>
-                                        <div
-                                            id={
-                                                `assignee-${tester.username}-` +
-                                                `completed`
-                                            }
-                                        >
+                                        <div id={getRowId(tester)}>
                                             {`(${testResults.reduce(
                                                 (acc, { completedAt }) =>
                                                     acc + (completedAt ? 1 : 0),