Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Candidate Tests Page Feedback #466

Open
evmiguel opened this issue Nov 1, 2022 · 7 comments
Open

Candidate Tests Page Feedback #466

evmiguel opened this issue Nov 1, 2022 · 7 comments
Labels
feedback Used by issues created from the ARIA-AT App

Comments

@evmiguel
Copy link
Contributor

evmiguel commented Nov 1, 2022

Please use this issue to document feedback for the Candidate Tests feature. The page can be accessed in sandbox: https://aria-at-app-sandbox.bocoup.com/candidate-tests

Feedback from @mcking65:

  • Separate start date into its own column.
  • Separate target date into its own column with the change target date button in the same cell as the date.
  • Put the change status button in the status column
  • Separate “Assertion Pass Rate column. This could allow sorting by pass rate
  • Include total assertions and tests in summary, e.g., instead of “10 assertions failed across 4 tests run with 1 browser”, use “10 of 200 assertions failed across 4 of 30 tests in 1 browser”
@evmiguel evmiguel added the feedback Used by issues created from the ARIA-AT App label Nov 1, 2022
@s3ththompson
Copy link
Member

I'm seeing an off-by-one time zone error on the "Mark as target date". Changing the date to "20-11-2022" for example, sets the target date to November 19, 2022. (I suspect this has something to do with dates being converted to timestamps at midnight, which then fall back to the previous day due to a time zone conversion...)

@s3ththompson
Copy link
Member

s3ththompson commented Nov 3, 2022 •
edited
Loading

From @jscholes:

  • The hierarchy of titles on the results summary seem to be inverted:

    • "Test results for Chrome" is just text
    • "Test result: Pass" is an H1
    • Ideally "Test results for Chrome" would be an H1 and "Test Result: Pass" would be an H2
    • Relatedly, the collapsible accordion pattern is not actually a disclosure element. It is not currently tab-focusable or keyboard accessible

    @mcking65 is also working on some updated copy here, which we could potentially incorporate when it's ready

@s3ththompson
Copy link
Member

s3ththompson commented Nov 3, 2022 •
edited by howard-e
Loading

From prior discussions with @mcking65 and @jscholes:

We should update the issue titles to more closely match the current tester feedback. This will need to be done with close attention with @howard-e's GitHub issue parsing code.

Suggested format: Apple Feedback: "Navigate to the last breadcrumb link" (Breadcrumb Example, Test 6)
or Apple Change Request: "Navigate to the last breadcrumb link" (Breadcrumb Example, Test 6)

Edit by @howard-e: eg of final format will be VoiceOver for macOS Feedback: "Navigate to the last breadcrumb link" (Breadcrumb Example, Test 6, 20-01-2022), where the DD-MM-YYYY date represents the date of when that version of the example was last updated on w3c/aria-at.

@evmiguel evmiguel mentioned this issue Nov 8, 2022
Merged
@evmiguel
Copy link
Contributor Author

evmiguel commented Nov 9, 2022

From @louis4533

  • "Viewing" announcement on current test
  • Previous and next navigation should announce current test as well

@s3ththompson
Copy link
Member

From @jscholes:

  • During testing, encountered strange behavior: navigated to last test using “next” button, pressed “finish” button…button disappeared initially, and then went back to “next”
  • Suggested copy change: after marking “not approved yet” and returning to index, the status for the test plan still shows “ready for review.” Ideally this should reflect, by some means, that the reviewer made it to the end of the review, cc @isaacdurazo

howard-e added a commit that referenced this issue Nov 21, 2022
@howard-e
Update created issue title based on #466 (comment)
b4150c1
@howard-e
Copy link
Contributor

howard-e commented Nov 23, 2022 •
edited
Loading

I'm seeing an off-by-one time zone error on the "Mark as target date". Changing the date to "20-11-2022" for example, sets the target date to November 19, 2022. (I suspect this has something to do with dates being converted to timestamps at midnight, which then fall back to the previous day due to a time zone conversion...)

Addressed by a9e85a3.

The hierarchy of titles on the results summary seem to be inverted

Addressed by 3dd975c.

We should update the issue titles to more closely match the current tester feedback.

Addressed by b4150c1. Note: Example of final format will be VoiceOver for macOS Feedback: "Navigate to the last breadcrumb link" (Breadcrumb Example, Test 6, 20-01-2022), where the DD-MM-YYYY date represents the date of when that version of the example was last updated on w3c/aria-at.

  • "Viewing" announcement on current test
  • Previous and next navigation should announce current test as well

Addressed by #472.

These fixes are now all included in #461.

howard-e added a commit that referenced this issue Nov 23, 2022
@evmiguel @howard-e
Candidate test run page (#461)
1ee7abb 
* thank you modal

* Thank you modal in new dir

* Upgrade storybook

* Setting up stories for ThankYouModal and ProvideFeedbackModal

* Adding ProvideFeedbackModal infra

* ProvideFeedbackModal with Bootstrap Form Controls

* ProvideFeedbackModal labels with icons

* Adding css file for ProvideFeedbackModal

* Remove ThankYouModal from TestRun

* form input group with button selection

* Adding common css and more css for ProvideFeedbackModal

* Button css

* CSS padding changes

* Adding radio change effect

* changing disabled to use states

* CSS

* Centering ThankYou modal

* Addressing feedback

* Addressing feedback

* Screen reader only for h1

* Storybook documentation

* Separating feedback items into own component

* Styling for mobile

* thank you modal

* Thank you modal in new dir

* Upgrade storybook

* Setting up stories for ThankYouModal and ProvideFeedbackModal

* Adding ProvideFeedbackModal infra

* ProvideFeedbackModal with Bootstrap Form Controls

* ProvideFeedbackModal labels with icons

* Adding css file for ProvideFeedbackModal

* Remove ThankYouModal from TestRun

* form input group with button selection

* Adding common css and more css for ProvideFeedbackModal

* Button css

* CSS padding changes

* Adding radio change effect

* changing disabled to use states

* CSS

* Centering ThankYou modal

* Addressing feedback

* Addressing feedback

* Screen reader only for h1

* Storybook documentation

* Adding test instructions to submitted content without styling

* Building out UI

* Test navigation

* handling github issues

* Vendors support and access

* useParams working on main component and storybook

* Recursive function for getting all issues through GitHub API

* add issuesResolver for testPlanReport; add phaseTargetDateResolver for testPlanReport; add migration file to add phaseChangeUpdate column to TestPlanReport

* Add caching around issues response; add testNumber to issue object in resolver

* Mocking github issues

* TestNavigator styling and TestRenderer(s) conditional

* Start to do indicators on feedback items

* Accordions

* Support for adding viewers to a test

* Move from GraphQL to REST based implementation to get repository's issues data

* Update tests

* Rename attribute

* Fix filter logic for issues response

* Fix link

* Address PR feedback; add candidate status change date, recommended status change date and recommended status target date to the database

* Previously viewed

* Fix storybook and target completion date

* Previously viewed badge

* Responsive

* Layout

* Update tests

* Fix basic auth config not being properly passed to GET function

* fixing runnable tests bug

* Feedback section styling

* Set default open for accordions

* Test Results container styling

* Vendor review status support

* Update cache for vendor review status only

* Adding href links to page

* Address test failures

* Updating auth test

* Updating imported tests and populate file

* Lock in aria-at commit for testing environment

* Cleaning up repeated code

* Adding loading and error pages

* Add viewers migration

* Marking last test

* Updating renderer for test instructions

* Removing hardcoded index

* Update css

* Publicize candidate test run pages

* separating vendor roles

* updating feedbacktype to new api

* sync issuesResolver

* Fixing queries to use Finalized results

* viewers performance

* Previously viewed

* Fix previously viewed

* Fix promote vendor status

* Test result pass or fail

* Integrate modals partially

* Styling on Results Accordion, Testing Instructions, and misc

* Fixing test indexing bug

* Github feedback backend

* Revert test renderer

* Test fixes

* Revert client/resources/aria-at-test-io-format.mjs

* Remove story for candidate test run page as it is too data intesive to add value

* Feedback list item styling

* Fixing review status promotion

* Add additional filters for testPlanReportsResolver.js; used filtered testPlanReports for CandidateTestPlanRun page

* Updating modals and visibility of change requests

* Fixing tests

* Revert storybook configs

* Reverting tests and removing dead code

* Adding missing field

* Setting default checked value for ProvideFeedbackModal

* Removing unused files and fixing test

* Fixing next test showing on finish bug

* Adjust review indicators on Candidate Test Queue page

* Update client/components/CandidateTestPlanRun/index.jsx

Co-authored-by: Howard Edwards <howarde.edwards@gmail.com>

* Revert feedbackType to IssueFeedbackType

* Removing TODOs in TestPlans component

* Add submit button styling

* Update client width in client/components/common/FeedbackListItem/FeedbackListItem.css

Co-authored-by: Howard Edwards <howarde.edwards@gmail.com>

* Update server/resolvers/addViewerResolver.js

Co-authored-by: Howard Edwards <howarde.edwards@gmail.com>

* Moving CandidateTestRun component and CandidateModals under CandidateTests tree

* Adjusting margin bottom for lines in issue container

* consistent timezone management between client & server

* Github issue links

* Fix auth

* Adding file AT bug links to specific AT issue trackers

* Update created issue title based on #466 (comment)

* Update Review Status Summary evaluation (feedback/candidate review numbers were getting duplicated across the columns for each AT)

* Add Test Plan Management page (#470)

* Start to test plan management page

* Add new Disclosure Component

* Update Test Plan Management page; update DisclosureComponent

* Add bulk update status resolver for TestPlanReport

* Split Summary Status Row into its own component to maintain focus and row update advantages; updating error message when bulk updating test plan report statuses to make it easier to find what report in the group prevents the update

* Update tests

* Update tests

* add additional test plan report status (RECOMMENDED); change FINALIZED -> CANDIDATE

* Change width at which navigation menu collapses due to more navigation options

* Make updates to reports related pages to account for Recommended Reports being shown

* Adjust vendorReviewStatus being changed in updateStatusResolver based on PR feedback

* Update content copy for Test Management and Reports page

* Update vendor review status being inferred for updateStatusResolver.js

* Remove unnecessary comment

* Temp removal of Test Management

* Remove unused reference

* Adjust logic for overall report approval status when CANDIDATE reports still exist

* Candidate Test Run Page - Disclosure Component and Screen Reader Announcement (#472)

* Using disclosure component and adding accessbility fixes

* Address console warning

* Update announcement when navigating through tests on Candidate Run Page

Co-authored-by: Howard Edwards <howarde.edwards@gmail.com>

Co-authored-by: Howard Edwards <howarde.edwards@gmail.com>
@howard-e
Copy link
Contributor

Some additional feedback from @louis4533:

  • “main” menu navigation and “main” landmark being announced separately might be confusing
  • Number of items in navigation menu list not being announced
  • The disclosures all being open might be redundant
    • Maybe consider having them all closed so a user may jump to the test Instructions or browser results for their needs.
    • If not, maybe consider just having the test instructions open.
  • Should consider announcing that the user is on the last test
    • Also, instead of the “Next” button changing to “Finish”, make the “Next” button disabled and add an extra “Finish” button

howard-e added a commit that referenced this issue Feb 9, 2023
@evmiguel @jscholes @howard-e
Accessibility feedback from #466 (#473)
90b1c29 
* Accessibility feedback

* Change 'Main Menu' accessible name on app nav to just 'Menu'

* Set buttons with aria-disabled

* Adjust focus when navigating between tests on Candidate Tests Run

---------

Co-authored-by: James Scholes <james@jamesscholes.com>
Co-authored-by: Howard Edwards <howarde.edwards@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feedback Used by issues created from the ARIA-AT App
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@s3ththompson @evmiguel @howard-e