Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Candidate test run page #461

Merged
merged 140 commits into from
Nov 23, 2022
Merged

Candidate test run page #461

merged 140 commits into from
Nov 23, 2022

Conversation

evmiguel
Copy link
Contributor

@evmiguel evmiguel commented Sep 21, 2022

This PR implements the Candidate Test Run Page and feedback modals as specified in this mockup and this design.

  1. Run yarn to install dependencies

Instructions for dev server:

  1. Run yarn sequelize db:migrate
  2. Run the app, and sign out if signed in.
  3. Sign in using the following http://localhost:3000/?fakeRole=vendor
  4. Access the page by going to http://localhost:3000/candidate-tests and selecting one of the test plans

@evmiguel evmiguel marked this pull request as ready for review October 3, 2022 15:20
@evmiguel evmiguel marked this pull request as draft October 3, 2022 15:20
recommendedStatusTargetDate
vendorReviewStatus
issues {
author
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mockup also includes a hyperlink on the text which says something like x people have left feedback for this test. My guess is that should be to the issue(s) (although I'm not sure how to account for multiple links visually, a pop up or so of applicable links? But this may be something to discuss internally).

But note that link is available in the query to get access to those GitHub issue links

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@s3ththompson @isaacdurazo how should we account for the multiple links in the case of x people have left feedback for this test?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great question! Sorry it is not clear in the mockups. Would it be possible to keep it as a single link that takes you to Github and display only the issues for that particular test once there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is possible. We'd just have to map a link with the right query to the component.

evmiguel and others added 2 commits November 7, 2022 16:20
…backListItem.css

Co-authored-by: Howard Edwards <howarde.edwards@gmail.com>
Co-authored-by: Howard Edwards <howarde.edwards@gmail.com>
Copy link
Contributor

@howard-e howard-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evmiguel looks good! Thanks for taking the time to incorporate the feedback!

server/controllers/AuthController.js Show resolved Hide resolved
howard-e and others added 7 commits November 21, 2022 15:52
…mbers were getting duplicated across the columns for each AT)
* Start to test plan management page

* Add new Disclosure Component

* Update Test Plan Management page; update DisclosureComponent

* Add bulk update status resolver for TestPlanReport

* Split Summary Status Row into its own component to maintain focus and row update advantages; updating error message when bulk updating test plan report statuses to make it easier to find what report in the group prevents the update

* Update tests

* Update tests

* add additional test plan report status (RECOMMENDED); change FINALIZED -> CANDIDATE

* Change width at which navigation menu collapses due to more navigation options

* Make updates to reports related pages to account for Recommended Reports being shown

* Adjust vendorReviewStatus being changed in updateStatusResolver based on PR feedback

* Update content copy for Test Management and Reports page

* Update vendor review status being inferred for updateStatusResolver.js

* Remove unnecessary comment
…uncement (#472)

* Using disclosure component and adding accessbility fixes

* Address console warning

* Update announcement when navigating through tests on Candidate Run Page

Co-authored-by: Howard Edwards <howarde.edwards@gmail.com>
@howard-e howard-e merged commit 1ee7abb into main Nov 23, 2022
@howard-e howard-e deleted the candidate-test-run-page branch November 23, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants