Ensure Each TestQueueRow Uses a Unique ID-ref.

[jkva]

This change ensures each id generated for a Test Queue Row combines its test plan ID and tester name. This addresses a problem where two test rows assigned to the same tester generate (elements with) duplicate IDs.

[jscholes]

@jkva I understand the intent behind this, but I'm not sure I understand the implementation/resulting mark-up. Each row in the test queue represents a test plan that can be assigned to multiple people, not just one.

[jkva]

@jscholes previously, you would get multiple elements with id assignee-[username]-completed, so in the case of multiple plans with the same assigned user, this would result in duplicate ids on the page.

[jscholes]

@jkva I looked at the rendered mark-up in the actual app as it is currently deployed, and this makes more sense now. The use of the word "row" is what was tripping me up. You're talking about a div, representing a tester's completion status, inside a list item, in an ul. But that content itself is inside a table. So when you said "row", I thought you meant a row of the table.

However, now that I understand it, I want to confirm that the proposed change fully resolves the issue. The Test Queue will contain multiple instances of the same plan, across different browser/AT combinations. If the same tester is assigned to the same plan across multiple combos, will the IDs still be unique?

[jkva]

That's a good use case for me to double-check, thank you.

[jkva]

@jscholes I've pushed a commit including the Test Plan Run ID within the generated ID, further guaranteeing uniqueness.

[howard-e]

LGTM other than the optional change request.

[howard-e]

Optional nitpick to address: I understand the id's original structure was being preserved with -completed being appended. Taking another look again at its use, perhaps something like -completed-tests is clearer for the id's purpose, but removing -completed altogether also works well and is helpful to reduce some of the id's verbosity.