Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Candidate test run page #461

Merged
merged 140 commits into from
Nov 23, 2022
Merged
Show file tree
Hide file tree
Changes from 120 commits
Commits
Show all changes
140 commits
Select commit Hold shift + click to select a range
2cc8e9c
thank you modal
evmiguel Aug 3, 2022
e74a390
Thank you modal in new dir
evmiguel Aug 4, 2022
b99dd77
Upgrade storybook
evmiguel Aug 8, 2022
68211b4
Setting up stories for ThankYouModal and ProvideFeedbackModal
evmiguel Aug 8, 2022
64377d9
Adding ProvideFeedbackModal infra
evmiguel Aug 8, 2022
9d48d6b
ProvideFeedbackModal with Bootstrap Form Controls
evmiguel Aug 9, 2022
5144f2a
ProvideFeedbackModal labels with icons
evmiguel Aug 9, 2022
3342b34
Adding css file for ProvideFeedbackModal
evmiguel Aug 9, 2022
ec697de
Remove ThankYouModal from TestRun
evmiguel Aug 9, 2022
28475d5
form input group with button selection
evmiguel Aug 10, 2022
5ddd9cc
Adding common css and more css for ProvideFeedbackModal
evmiguel Aug 10, 2022
08f0ebe
Button css
evmiguel Aug 10, 2022
a992514
CSS padding changes
evmiguel Aug 10, 2022
866f33b
Adding radio change effect
evmiguel Aug 11, 2022
e1f29ff
changing disabled to use states
evmiguel Aug 11, 2022
95595fa
CSS
evmiguel Aug 15, 2022
c1dd734
Centering ThankYou modal
evmiguel Aug 15, 2022
712425a
Addressing feedback
evmiguel Aug 18, 2022
238aed0
Addressing feedback
evmiguel Aug 18, 2022
1b3967a
Screen reader only for h1
evmiguel Aug 22, 2022
8c800b5
Storybook documentation
evmiguel Aug 22, 2022
911d4ff
Separating feedback items into own component
evmiguel Sep 26, 2022
7c3dacb
Styling for mobile
evmiguel Sep 27, 2022
c05bfb8
thank you modal
evmiguel Aug 3, 2022
20af9c8
Thank you modal in new dir
evmiguel Aug 4, 2022
1f27bf1
Upgrade storybook
evmiguel Aug 8, 2022
7abfdad
Setting up stories for ThankYouModal and ProvideFeedbackModal
evmiguel Aug 8, 2022
5d81f7f
Adding ProvideFeedbackModal infra
evmiguel Aug 8, 2022
508f93d
ProvideFeedbackModal with Bootstrap Form Controls
evmiguel Aug 9, 2022
af0e602
ProvideFeedbackModal labels with icons
evmiguel Aug 9, 2022
addd650
Adding css file for ProvideFeedbackModal
evmiguel Aug 9, 2022
ff5cc36
Remove ThankYouModal from TestRun
evmiguel Aug 9, 2022
2177f2e
form input group with button selection
evmiguel Aug 10, 2022
3ef5438
Adding common css and more css for ProvideFeedbackModal
evmiguel Aug 10, 2022
7a4f21f
Button css
evmiguel Aug 10, 2022
7cd70c8
CSS padding changes
evmiguel Aug 10, 2022
7f4d67b
Adding radio change effect
evmiguel Aug 11, 2022
e91e6a2
changing disabled to use states
evmiguel Aug 11, 2022
eb8d648
CSS
evmiguel Aug 15, 2022
a172df6
Centering ThankYou modal
evmiguel Aug 15, 2022
6789647
Addressing feedback
evmiguel Aug 18, 2022
d0877b8
Addressing feedback
evmiguel Aug 18, 2022
31b70e6
Screen reader only for h1
evmiguel Aug 22, 2022
d6deee3
Storybook documentation
evmiguel Aug 22, 2022
6019bde
Adding test instructions to submitted content without styling
evmiguel Aug 23, 2022
f885435
Building out UI
evmiguel Aug 24, 2022
bfca76a
Test navigation
evmiguel Aug 25, 2022
8b47d3c
handling github issues
evmiguel Aug 25, 2022
4d6d42a
Vendors support and access
evmiguel Aug 30, 2022
68f5306
useParams working on main component and storybook
evmiguel Aug 30, 2022
d74f6d6
Recursive function for getting all issues through GitHub API
howard-e Aug 24, 2022
9c10798
add issuesResolver for testPlanReport; add phaseTargetDateResolver fo…
howard-e Aug 25, 2022
46b838c
Add caching around issues response; add testNumber to issue object in…
howard-e Aug 25, 2022
1123e2b
Mocking github issues
evmiguel Aug 30, 2022
f4fc5ff
TestNavigator styling and TestRenderer(s) conditional
evmiguel Sep 6, 2022
3257fa7
Start to do indicators on feedback items
evmiguel Sep 6, 2022
02c140a
Accordions
evmiguel Sep 7, 2022
d3767b5
Support for adding viewers to a test
evmiguel Sep 8, 2022
ae531b2
Move from GraphQL to REST based implementation to get repository's is…
howard-e Aug 29, 2022
d761ee8
Update tests
howard-e Aug 29, 2022
4d0eccb
Rename attribute
howard-e Aug 29, 2022
2737692
Fix filter logic for issues response
howard-e Aug 29, 2022
4ee0be9
Fix link
howard-e Aug 29, 2022
c257c31
Address PR feedback; add candidate status change date, recommended st…
howard-e Sep 12, 2022
e4dc746
Previously viewed
evmiguel Sep 12, 2022
36a4176
Fix storybook and target completion date
evmiguel Sep 13, 2022
ae8eb5c
Previously viewed badge
evmiguel Sep 13, 2022
8c4ba5b
Responsive
evmiguel Sep 13, 2022
20ce995
Layout
evmiguel Sep 13, 2022
b6f79f7
Update tests
howard-e Sep 12, 2022
4d36787
Fix basic auth config not being properly passed to GET function
howard-e Sep 14, 2022
8bd2b54
fixing runnable tests bug
evmiguel Sep 14, 2022
b9f2f36
Feedback section styling
evmiguel Sep 15, 2022
307a809
Set default open for accordions
evmiguel Sep 15, 2022
9d652ab
Test Results container styling
evmiguel Sep 19, 2022
91f0f96
Vendor review status support
evmiguel Sep 19, 2022
26c5019
Update cache for vendor review status only
evmiguel Sep 20, 2022
90b394b
Adding href links to page
evmiguel Sep 20, 2022
d628f6c
Address test failures
evmiguel Sep 21, 2022
1423173
Updating auth test
evmiguel Sep 21, 2022
cd86268
Updating imported tests and populate file
evmiguel Sep 21, 2022
d562b5f
Lock in aria-at commit for testing environment
evmiguel Sep 21, 2022
d3e884d
Cleaning up repeated code
evmiguel Sep 27, 2022
0787f23
Adding loading and error pages
evmiguel Sep 27, 2022
d50fa77
Add viewers migration
evmiguel Sep 28, 2022
963f30d
Marking last test
evmiguel Sep 28, 2022
c41f22a
Updating renderer for test instructions
evmiguel Sep 28, 2022
a96a7d6
Removing hardcoded index
evmiguel Oct 3, 2022
993d493
Update css
evmiguel Oct 3, 2022
1469982
Publicize candidate test run pages
evmiguel Oct 17, 2022
c3b46ab
separating vendor roles
evmiguel Oct 17, 2022
ab72ec1
updating feedbacktype to new api
evmiguel Oct 18, 2022
0b04182
sync issuesResolver
evmiguel Oct 18, 2022
e678720
Fixing queries to use Finalized results
evmiguel Oct 18, 2022
7953354
viewers performance
evmiguel Oct 18, 2022
5a04820
Previously viewed
evmiguel Oct 19, 2022
5bfb833
Fix previously viewed
evmiguel Oct 19, 2022
eb66784
Fix promote vendor status
evmiguel Oct 19, 2022
6dae036
Test result pass or fail
evmiguel Oct 19, 2022
5ca5a1f
Merge branch 'candidate-modals' into candidate-test-run-page
evmiguel Oct 24, 2022
2e45c5d
Integrate modals partially
evmiguel Oct 25, 2022
52711d1
Styling on Results Accordion, Testing Instructions, and misc
evmiguel Oct 25, 2022
86588f1
Fixing test indexing bug
evmiguel Oct 25, 2022
241e302
Github feedback backend
evmiguel Oct 25, 2022
16cf038
Revert test renderer
evmiguel Oct 26, 2022
89bf33a
Test fixes
evmiguel Oct 26, 2022
addff9c
Revert client/resources/aria-at-test-io-format.mjs
evmiguel Oct 26, 2022
1628539
Remove story for candidate test run page as it is too data intesive t…
evmiguel Oct 26, 2022
d225d9a
Feedback list item styling
evmiguel Oct 26, 2022
7fcb55b
Fixing review status promotion
evmiguel Oct 27, 2022
4cd2e2f
Add additional filters for testPlanReportsResolver.js; used filtered …
howard-e Oct 27, 2022
006283a
Merge remote-tracking branch 'origin/candidate-test-run-page' into ca…
howard-e Oct 27, 2022
afcb4e9
Updating modals and visibility of change requests
evmiguel Oct 27, 2022
fd76c4f
Fixing tests
evmiguel Oct 27, 2022
8ec0773
Revert storybook configs
evmiguel Oct 31, 2022
b9b363d
Reverting tests and removing dead code
evmiguel Nov 1, 2022
9f74cdf
Adding missing field
evmiguel Nov 1, 2022
2884f42
Setting default checked value for ProvideFeedbackModal
evmiguel Nov 1, 2022
660942a
Removing unused files and fixing test
evmiguel Nov 1, 2022
21e27da
Fixing next test showing on finish bug
evmiguel Nov 1, 2022
b98e12f
Adjust review indicators on Candidate Test Queue page
howard-e Nov 3, 2022
f09abaa
Update client/components/CandidateTestPlanRun/index.jsx
evmiguel Nov 7, 2022
bea2d2d
Revert feedbackType to IssueFeedbackType
evmiguel Nov 7, 2022
bee1740
Removing TODOs in TestPlans component
evmiguel Nov 7, 2022
31e049e
Add submit button styling
evmiguel Nov 7, 2022
803c91d
Update client width in client/components/common/FeedbackListItem/Feed…
evmiguel Nov 7, 2022
3065d0b
Update server/resolvers/addViewerResolver.js
evmiguel Nov 7, 2022
1397fdf
Moving CandidateTestRun component and CandidateModals under Candidate…
evmiguel Nov 8, 2022
ad790f2
Adjusting margin bottom for lines in issue container
evmiguel Nov 8, 2022
a9e85a3
consistent timezone management between client & server
howard-e Nov 10, 2022
a300a5a
Github issue links
evmiguel Nov 14, 2022
bd688a8
Fix auth
evmiguel Nov 14, 2022
7b045de
Adding file AT bug links to specific AT issue trackers
evmiguel Nov 14, 2022
b4150c1
Update created issue title based on https://github.com/w3c/aria-at-ap…
howard-e Nov 21, 2022
25c8afa
Update Review Status Summary evaluation (feedback/candidate review nu…
howard-e Nov 21, 2022
8a96d36
Add Test Plan Management page (#470)
howard-e Nov 22, 2022
5919192
Temp removal of Test Management
howard-e Nov 22, 2022
827c8d6
Remove unused reference
howard-e Nov 22, 2022
569996a
Adjust logic for overall report approval status when CANDIDATE report…
howard-e Nov 23, 2022
ed312d9
Candidate Test Run Page - Disclosure Component and Screen Reader Anno…
evmiguel Nov 23, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions client/.storybook/config.js

This file was deleted.

3 changes: 2 additions & 1 deletion client/.storybook/main.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
module.exports = {
addons: ['@storybook/addon-actions/register']
stories: ['../stories/*.stories.jsx'],
addons: ['@storybook/addon-a11y', '@storybook/addon-controls']
};
4 changes: 4 additions & 0 deletions client/.storybook/preview.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
import '../../node_modules/bootstrap/dist/css/bootstrap.css';
import '../../node_modules/@fortawesome/fontawesome-svg-core/styles.css';
import '!style-loader!css-loader!sass-loader!../scss/custom.scss'; // using inline webpack loaders for scss
import '../static/index.css';
30 changes: 15 additions & 15 deletions client/components/App/App.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const App = () => {
const [isNavbarExpanded, setIsNavbarExpanded] = useState(false);

const auth = evaluateAuth(data && data.me ? data.me : {});
const { username, isSignedIn, /*isAdmin,*/ isVendor } = auth;
const { username, isSignedIn, isAdmin, isVendor } = auth;

const signOut = async () => {
await fetch('/api/auth/signout', { method: 'POST' });
Expand Down Expand Up @@ -80,20 +80,20 @@ const App = () => {
Test Queue
</Nav.Link>
</li>
{/*{isSignedIn && (isAdmin || isVendor) && (*/}
{/* <li>*/}
{/* <Nav.Link*/}
{/* as={Link}*/}
{/* to="/candidate-tests"*/}
{/* aria-current={*/}
{/* location.pathname ===*/}
{/* '/candidate-tests'*/}
{/* }*/}
{/* >*/}
{/* Candidate Tests*/}
{/* </Nav.Link>*/}
{/* </li>*/}
{/*)}*/}
{isSignedIn && (isAdmin || isVendor) && (
<li>
<Nav.Link
as={Link}
to="/candidate-tests"
aria-current={
location.pathname ===
'/candidate-tests'
}
>
Candidate Tests
</Nav.Link>
</li>
)}
{isSignedIn && (
<>
{!isVendor && (
Expand Down
154 changes: 154 additions & 0 deletions client/components/CandidateTestPlanRun/CandidateTestPlanRun.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,154 @@
.card-body {
padding: 0;
}

.card-body > div {
border: none;
}

.current-test-title {
border: none;
}

.current-test-options .options-wrapper {
text-align: center;
}

.current-test-options .options-wrapper li {
margin-bottom: 0.5em;
}

.current-test-options .options-wrapper li:last-child {
margin-bottom: 0;
}

.feedback-accordion {
width: 100%;
}

.feedback-accordion-header {
display: grid;
grid-template-columns: 50% 50%;
}

.feedback-accordion-header span {
text-align: right;
}

.feedback-from-text {
font-weight: 400;
}

.feedback-list-item {
padding: 1em 0 1em 0.5em;
position: relative;
margin: 1em 0 1em 0em;
list-style: none;
font-size: 14px;
border: solid 1px #e5e5e5;
width: 100%;
}

.feedback-indicator {
position: absolute;
left: -2em;
top: 1.3em;
width: 16px;
height: 16px;
border-radius: 50px;
border: 2px solid #9a9a9a;
}

.feedback-list-item:before {
content: '';
position: absolute;
height: 2.3em;
width: 2px;
top: -1.1em;
left: -1.5em;
background: #d2d5d9;
}

.feedback-list-item:after {
content: '';
position: absolute;
height: calc(100% - 1.3em);
width: 2px;
bottom: -1.2em;
left: -1.5em;
background: #d2d5d9;
}

.feedback-list-item .feedback-indicator {
background: white;
}

.issues-container {
max-width: 800px;
evmiguel marked this conversation as resolved.
Show resolved Hide resolved
}

.issues-container > h2 {
margin: 0 0 0.5em;
font-size: 18px;
padding-bottom: 5px;
border-bottom: solid 1px #e5e5e5;
}

.task-label {
font-size: 18px !important;
}

.test-results-header,
.test-instructions-header {
border-bottom: none;
}

.review-status,
.target-date,
.apg-example-name {
width: 32% !important;
}

.results-container {
padding: 0px;
}

.results-container-col {
padding: 0;
}

.results-container-row {
border: solid 1px #e5e5e5;
padding: 1em;
}

.options-feedback {
top: 35px;
}

.test-results-header {
border-bottom: none;
margin: 0;
padding: 20px;
font-size: 20px;
background-color: #f5f8fa;
border: #e5efe8 1px solid;
}

.test-results-table {
margin-bottom: 0;
border-left: none;
}

.using {
font-weight: 300;
}

.viewed-badge {
background-color: #e5e5e5;
color: black;
font-size: 15px;
font-weight: 400;
position: relative;
top: -5px;
}
Loading