DO NOT MERGE: demonstrate Build Linter failure for #1365 #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t is run The command to regenerate is: npm run build The new lint command is: npm run lint:build Document this in the README. Run the new lint in Travis CI to ensure that PRs that change something under examples/ also regenerate the index. Fixes #1079.
carmacleod
reviewed
Apr 3, 2020
nschonni
added a commit
to nschonni/aria-practices
that referenced
this pull request
Sep 10, 2020
nschonni
added a commit
to nschonni/aria-practices
that referenced
this pull request
Sep 10, 2020
nschonni
added a commit
to nschonni/aria-practices
that referenced
this pull request
Sep 10, 2020
nschonni
added a commit
to nschonni/aria-practices
that referenced
this pull request
Sep 25, 2020
nschonni
added a commit
to nschonni/aria-practices
that referenced
this pull request
Sep 29, 2020
nschonni
added a commit
to nschonni/aria-practices
that referenced
this pull request
Sep 29, 2020
nschonni
added a commit
to nschonni/aria-practices
that referenced
this pull request
Sep 29, 2020
nschonni
added a commit
to nschonni/aria-practices
that referenced
this pull request
Sep 30, 2020
nschonni
added a commit
to nschonni/aria-practices
that referenced
this pull request
Sep 30, 2020
nschonni
added a commit
to nschonni/aria-practices
that referenced
this pull request
Sep 30, 2020
nschonni
added a commit
to nschonni/aria-practices
that referenced
this pull request
Oct 1, 2020
nschonni
added a commit
to nschonni/aria-practices
that referenced
this pull request
Oct 12, 2020
nschonni
added a commit
to nschonni/aria-practices
that referenced
this pull request
Oct 12, 2020
nschonni
added a commit
to nschonni/aria-practices
that referenced
this pull request
Oct 21, 2020
nschonni
added a commit
to nschonni/aria-practices
that referenced
this pull request
Oct 21, 2020
nschonni
added a commit
to nschonni/aria-practices
that referenced
this pull request
Oct 23, 2020
nschonni
added a commit
to nschonni/aria-practices
that referenced
this pull request
Oct 25, 2020
nschonni
added a commit
to nschonni/aria-practices
that referenced
this pull request
Oct 25, 2020
nschonni
added a commit
to nschonni/aria-practices
that referenced
this pull request
Nov 8, 2020
nschonni
added a commit
to nschonni/aria-practices
that referenced
this pull request
Nov 14, 2020
nschonni
added a commit
to nschonni/aria-practices
that referenced
this pull request
Dec 1, 2020
|
Closing in favor of: #1524 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1365. Do not merge this PR.
The second commit here changes
examples/accordion/accordion.htmlfromaria-expanded="true"toaria-busy="true", which would cause a change to the index. The expectation is that the new Build Linter check will fail in Travis CI.