-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slider thermostat update from focus group meeting results #1755
Closed
Closed
Changes from 42 commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
94a201e
updated slider thermostat example
jongund 4ffb3f3
changed mouse to pointre events
jongund 6b7f123
updated thermostat slider example to use pointer events
jongund 9a9cdfd
updated regression tests to handle fixed point values
jongund 9d23850
fixed html lintning bugs
jongund 43b0c2e
fixed label bug
jongund bd029cd
fixed spelling bugs
jongund a01f526
added touch action
jongund 512b738
added test to slider-thermostat
jongund 8a1457d
added touch advisement
jongund 96d161b
added meta tag, removed output element and updated code to limit value
jongund 46d44af
update thermostate slider to use SVG for buttons and temperatiure label
jongund 13d7ba4
updated documentation and test cases for SVG buttons
jongund 7eb3d92
fixed button keyboard tests
jongund fbfa8ce
updated documentation
jongund d46d44b
fixed linting bug
jongund e7cb21d
removed outer focus ring and updated documentation
jongund 685aef1
added documentation about using inline SVG
jongund 5994034
updated documentation
jongund a2925e5
updated documentation page up and down keys
jongund eb553e5
updated warning documentation
jongund 431ed2f
updated thermostat example to remove buttons and update reference links
jongund ae54aed
updated regression tests
jongund bfe0a82
fixing linter issues
jongund d0149a2
updated reference tables
jongund 3636aea
updated documentation
jongund c8bec70
removed focus and blur event handlers
jongund 1dfbbba
restored CSS
jongund 5ecf7c2
fixed currentColor issue in high contast
jongund 09c49a5
updated code to set the value used by the SVG onload based on current…
jongund e1c769f
flixed linting errors
jongund b17a15b
flixed linting errors
jongund 3ba5d26
updated documentation on defining the color attribute on the SVG elem…
jongund ec91f48
updated documentation on defining the color attribute on the SVG elem…
jongund de3da6d
updated documentation on defining the color attribute on the SVG elem…
jongund add99db
updated example to use none on SVG elements and hide fan labels
jongund cc67bf9
updated reference tables
jongund 3f53489
changed role=none ot role=presentation due to linting error
jongund 51fe8c7
updated regression test to use role=presentation
jongund 593c6c4
Merge branch 'main' into slider-thermostat-update
jongund 6262ea8
updated reference tables
jongund bcbdeed
added validator exception
jongund 54857fc
added validator exception
jongund 27c01df
changed role to none on SVG elements
jongund 61f3cb0
updated documentation and JS initialization script
jongund 7a927c6
fixed miss spelled word and updated CSS
jongund bd7967a
updated documentation
jongund File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| #!/bin/sh | ||
| if [ -z "$husky_skip_init" ]; then | ||
| debug () { | ||
| [ "$HUSKY_DEBUG" = "1" ] && echo "husky (debug) - $1" | ||
| } | ||
|
|
||
| readonly hook_name="$(basename "$0")" | ||
| debug "starting $hook_name..." | ||
|
|
||
| if [ "$HUSKY" = "0" ]; then | ||
| debug "HUSKY env variable is set to 0, skipping hook" | ||
| exit 0 | ||
| fi | ||
|
|
||
| if [ -f ~/.huskyrc ]; then | ||
| debug "sourcing ~/.huskyrc" | ||
| . ~/.huskyrc | ||
| fi | ||
|
|
||
| export readonly husky_skip_init=1 | ||
| sh -e "$0" "$@" | ||
| exitCode="$?" | ||
|
|
||
| if [ $exitCode != 0 ]; then | ||
| echo "husky - $hook_name hook exited with code $exitCode (error)" | ||
| exit $exitCode | ||
| fi | ||
|
|
||
| exit 0 | ||
| fi |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| /* CSS Document */ | ||
|
|
||
| .thermostat h3 { | ||
| color: black; | ||
| font-weight: bold; | ||
| font-size: 150%; | ||
| } | ||
|
|
||
| .slider-thermostat-vertical .slider-group { | ||
| touch-action: pan-x; | ||
| } | ||
|
|
||
| .slider-thermostat-text .slider-group { | ||
| touch-action: pan-y; | ||
| } | ||
|
|
||
| .slider-thermostat { | ||
| margin-top: 1em; | ||
| padding: 6px; | ||
| width: 12em; | ||
| color: black; | ||
| } | ||
|
|
||
| .slider-thermostat.text { | ||
| width: 14em; | ||
| } | ||
|
|
||
| .slider-thermostat .label { | ||
| font-weight: bold; | ||
| fill: currentColor; | ||
| color: currentColor; | ||
| } | ||
|
|
||
| .slider-thermostat .value { | ||
| position: relative; | ||
| top: 20px; | ||
| height: 1.5em; | ||
| font-size: 80%; | ||
| fill: currentColor; | ||
| } | ||
|
|
||
| .slider-thermostat.vertical .temp-value { | ||
| padding-left: 24px; | ||
| font-weight: bold; | ||
| font-size: 200%; | ||
| font-family: sans-serif; | ||
| fill: currentColor; | ||
| color: currentColor; | ||
| } | ||
|
|
||
| .slider-thermostat .rail { | ||
| stroke: currentColor; | ||
| stroke-width: 2px; | ||
| fill: currentColor; | ||
| fill-opacity: 25%; | ||
| } | ||
|
|
||
| .slider-thermostat .thumb { | ||
| stroke-width: 0; | ||
| fill: currentColor; | ||
| } | ||
|
|
||
| .slider-thermostat .focus { | ||
| stroke-width: 3px; | ||
| stroke: transparent; | ||
| fill: transparent; | ||
| } | ||
|
|
||
| .slider-thermostat.text .value-label rect { | ||
| fill: transparent; | ||
| stroke-width: 2px; | ||
| stroke: transparent; | ||
| } | ||
|
|
||
| .slider-thermostat.text .value-label text { | ||
| fill: currentColor; | ||
| font-weight: bold; | ||
| } | ||
|
|
||
| /* Focus and hover styling */ | ||
|
|
||
| .slider-thermostat.text .value-label:hover rect { | ||
| stroke: currentColor; | ||
| } | ||
|
|
||
| .slider-thermostat.focus [role="slider"] { | ||
| color: #005a9c; | ||
| } | ||
|
|
||
| .slider-thermostat.focus [role="slider"] .rail { | ||
| stroke: currentColor; | ||
| fill: #adddff; | ||
| } | ||
|
|
||
| .slider-thermostat [role="slider"]:focus { | ||
| outline: none; | ||
| } | ||
|
|
||
| .slider-thermostat [role="slider"]:focus .focus { | ||
| stroke: currentColor; | ||
| } | ||
|
|
||
| .slider-thermostat [role="slider"]:focus .thumb { | ||
| fill: currentColor; | ||
| } | ||
|
|
||
| .slider-thermostat.vertical [role="slider"]:focus .value { | ||
| font-weight: bold; | ||
| fill: currentColor; | ||
| } |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The supressions work by string matching, so it's the exact error message (or a regex)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nschonni