Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch Role: Example using the DIV element #1892

Merged
merged 55 commits into from
Oct 4, 2021
Merged

Switch Role: Example using the DIV element #1892

merged 55 commits into from
Oct 4, 2021

Conversation

jongund
Copy link
Contributor

@jongund jongund commented May 5, 2021 •
edited by pr-preview bot
Loading

Michiel Bijl and others added 30 commits July 17, 2017 18:27
Add basis code
3b972ac
Fix switch functionality
198a699
Add keyboard support
0ba2018
Add line about where to comment
01babec
Remove enter key as an activation key
24f2fc7
@mcking65
Merge branch 'master' into switch
0aedd74
@jongund @mcking65
Add draft of switch design pattern (pull #788)
c6d2ddb 
For issue #162, add draft of design pattern that links to current draft of example.
@mcking65
Switch Pattern: add note with link to development issue
6194469 
Modified the draft switch section in aria-practices.html to add a link to development issue 162.
@mcking65
Switch Example: Add header nav and make minor editorial revisions.
fa3d3c3
@mcking65
Merge branch 'master' into switch
a39fe5f
@mcking65
Merge branch 'master' into switch
40d10e3
Add basis code
e37e753
Fix switch functionality
55afcf7
Add keyboard support
639bbda
Add line about where to comment
32ae95a
Remove enter key as an activation key
8ea5ed1
@jongund
Add draft of switch design pattern (pull #788)
9c4da45 
For issue #162, add draft of design pattern that links to current draft of example.
@mcking65
Switch Pattern: add note with link to development issue
09a4dc4 
Modified the draft switch section in aria-practices.html to add a link to development issue 162.
@mcking65
Switch Example: Add header nav and make minor editorial revisions.
8a6c110
#243 Update Switch JS/CSS/HTML
4830d6a
Merge branch 'switch' of github.com:w3c/aria-practices into switch
ff76296
@mcking65
Merge branch 'master' into switch
5fe0eff
@jongund
Merge branch 'master' into switch
146ae8a
@jongund
Merge branch 'main' into switch
da6f59f
@jongund
initial implementation of a switch that supports HC
278e3d2
@jongund
intial implementation of a switch example using a DIV element
e4a9fce
@jongund
fixed spelling issues
d7fa02f
@jongund
updated documentation and hover styling
5d90774
@jongund
update cspell
99058e9
@jongund
update cspell
b744849
@jongund
Copy link
Contributor Author

jongund commented Sep 21, 2021

@a11ydoer @mcking65

  • High contrast support has been fixed.
  • Added aria-hidden to on and off labels
  • Updated documentation to follow switch chackbox example

@a11ydoer
Copy link
Contributor

@jongund sorry for delayed review. I tested with android in Google phone.

The switch works well with double tap in turning on and off. One problem is the responsive view in mobile phone - switch looks too small so I had to zoom in. However, this will be resolved when APG redesign project is completed. Thanks for all your work!

@a11ydoer a11ydoer mentioned this pull request Sep 28, 2021
Merged
8 tasks
@mcking65
Copy link
Contributor

mcking65 commented Oct 3, 2021

@jongund
Since we already have grouping in the other two examples of switch, it seems unnecessary in this one. It is helpful to have a really basic example, especially for the aria-at project.

Would you be OK with reducing this to a single switch labeled "Notifications"?

I've finished all other editorial revisions/review on this one. I'll complete the review process after we decide about grouping.

@jongund
Copy link
Contributor Author

jongund commented Oct 4, 2021

@mcking65
I updated the example to have just a single "notification" switch.

mcking65
mcking65 approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial review complete. Looks awesome, thank you @jongund !

@mcking65 mcking65 merged commit 594fe37 into main Oct 4, 2021
@mcking65 mcking65 deleted the switch branch October 4, 2021 16:25
@mcking65 mcking65 added the Example Page Related to a page containing an example implementation of a pattern label Oct 5, 2021
@mcking65 mcking65 added this to the 1.2 Release 1 milestone Oct 5, 2021
@mcking65 mcking65 mentioned this pull request Oct 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcking65 mcking65 mcking65 approved these changes

@a11ydoer a11ydoer a11ydoer approved these changes

@jesdaigle jesdaigle jesdaigle approved these changes

Assignees
No one assigned
Labels
Example Page Related to a page containing an example implementation of a pattern
Projects
Switch pattern and example developmen...
Complete
Milestone
1.2 Release 1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jongund @a11ydoer @mcking65 @jesdaigle