Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor Menubar Example: Add notes about hover and focus movement #711

Merged
merged 12 commits into from Jun 27, 2018
Merged

Editor Menubar Example: Add notes about hover and focus movement #711

merged 12 commits into from Jun 27, 2018

Conversation

mcking65
Copy link
Contributor

@mcking65 mcking65 commented Jun 12, 2018 •
edited by pr-preview bot

For issue #603, modified: examples/menubar/menubar-2/menubar-2.html.
In the accessibility features section, added items 4 and 5 describing the conditions when mouse hover can move focus.

Preview | Diff

@mcking65
Editor Menubar Example: Add notes about hover and focus movement
9eea445 
For issue #603, modified: examples/menubar/menubar-2/menubar-2.html.
In the accessibility features section, added items 4 and 5 describing the conditions when mouse hover can move focus.
@mcking65
Copy link
Contributor Author

mcking65 commented Jun 12, 2018 •
edited

@annabbott,

To preview this change, go to the editor menubar example in the issue 603 branch and scroll down to the "Accessibility Features" section under the example. This change adds items 4 and 5 to the list in that section. Please review the wording in those items. You can leave a comment here, on the conversation tab, or on the files tab of this pull request where you can see the HTML for the changes.

aristov and others added 10 commits June 24, 2018 16:51
@aristov @mcking65
Treeview examples: fix blink on hover (pull #689)
8ccab11 
For issue #712, change CSS so hovering to right of tree does not cause blinking.
@mcking65
Collapsible Listbox example: Add missing aria-labelledby to documenta…
386113e 
…tion table

For issue #584, modified listbox-collapsible.html.
In the roles, states, and properties table,
added row to document the use of aria-labelledby on the button element.
@jnurthen @mcking65
Landmark Regions: Fix labeling requirement issue #453 (#687)
87d5739 
Editorial clarification to landmark labeling guidance to explain when unique labels are needed and when duplicate labels may be appropriate.
@mcking65
TRAVIS-CI update from aria-common
036156a
@jongund @mcking65
Treegrid Design Pattern: Initial draft (pull #714)
9297330 
For issue #91, add a draft of pattern section for treegrid.
@danielmatthew @mcking65
Fix typo: overlayed/overlaid
e3e3d2f
@jnurthen @mcking65
Tabs Pattern: Clarify where focus should go when deleting tabs to fix…
c59c2e9 
… issue 602 (pull #683)

To resolve issue #602:
- Clarified description of deleting the tab at the end of the tab list
- For where to move focus after last remaining tab was deleted, borrowed logical work flow language from button and dialog patterns.
- Added missing "optionally" for activation.
- Added missing optional tab activation statement to home and end key commands.
@jongund @mcking65
Radio Group Examples: Style both button and label on focus and hover …
72ea89c 
…(pull #703)

For issue #568:
* Updated keyboard focus styling to include border around both the radio button and label
* Updated hover style to highlight both the radio button and the label
@robfentress @mcking65
Navigation menu button example: collapse menu when clicking button (p…
a41d540 
…ull #731)

For issue #695, change so that if the menu is displayed and the menu button is activated, the menu is collapsed.
@jongund @mcking65
Editor menubar example: Make Escape close submenu when focus in menub…
7d22fe4 
…ar (pull #723)

For issue #451:
* Adds ability to close open submenu  with Escape key when focus is in menubar.
* Add row to menubar keyboard table for Escape key.
@mcking65 mcking65 changed the base branch from master to apg-1.2 June 24, 2018 23:56
@mcking65 mcking65 changed the base branch from apg-1.2 to master June 24, 2018 23:57
@mcking65 mcking65 changed the base branch from master to apg-1.2 June 25, 2018 00:02
@mcking65 mcking65 changed the base branch from apg-1.2 to master June 25, 2018 00:05
@mcking65
Copy link
Contributor Author

Well, stackoverflow suggested I could clean up the commit list for the PR by changing the base branch to another branch and then changing back ... no such luck. I'm not going to bother creating a new PR just because of a rebase to bring this branch up to date. There is only one file change in this branch that is not in master ... the one in the menubar2 html file. The other 10 commits that are showing up in the commit list are already in master. They only got into this PR when I rebased the branch on top of master to make sure the latest changes to editor menubar would merged cleanly with this one. Sometimes github is not optimal.

@annabbott
Copy link

"Accessibility Features" > items 4 and 5 look good.
Found one nit: "Accessibility Features" > item 2: remove extra space after last word of sentence and the period.
Also added this comment to #603 (instructions were confusing).

@annabbott annabbott mentioned this pull request Jun 27, 2018
Closed
@mcking65
Copy link
Contributor Author

@annabbott, thanks for the review. I removed the extra space.

@mcking65 mcking65 merged commit eafc098 into master Jun 27, 2018
@mcking65 mcking65 deleted the issue603 branch June 27, 2018 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnurthen jnurthen Awaiting requested review from jnurthen

@annabbott annabbott Awaiting requested review from annabbott

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mcking65 @annabbott @aristov @jnurthen @jongund @danielmatthew @robfentress