Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Examples: Validate HTML and CSS #174

Closed
8 tasks done
ZoeBijl opened this issue Jan 12, 2016 · 5 comments
Closed
8 tasks done

Code Examples: Validate HTML and CSS #174

ZoeBijl opened this issue Jan 12, 2016 · 5 comments
Assignees

Comments

@ZoeBijl
Copy link

ZoeBijl commented Jan 12, 2016

As Karl pointed out, all code examples should be validated.

  • Button
  • Alert
  • Checkbox 1
  • Checkbox 3
  • Link
  • Radio
  • Slider 1
  • Slider 2

For those wondering: I've removed all role="main" attributes. These trigger a warning in the validator. Besides, the main element should suffice; there are no other structural landmarks.

@karlgroves
Copy link

As this tends to relate to other issues, such as #88, #131, and #95, it might make sense to introduce at least one important dependency: Grunt. You can add some sensible Grunt tasks to handle some of this stuff. LMK if the WG would like some help here.

@ZoeBijl
Copy link
Author

ZoeBijl commented Jan 12, 2016

I think we better start with the simple addition of an .editorconfig file and go from there. We need to see how that impacts the people working on this. To be honest, I'm not sure about adding dependencies on this. (I feel) this is stuff is not all that complicated. On the other hand, automated HTML validation and the like would be a plus.

@ZoeBijl
Copy link
Author

ZoeBijl commented Jan 13, 2016

I have validated all examples (the code still needs cleaning up, but that is a different issue): fadbd7f

@karlgroves I'll let you know if we're going forward with adding something like grunt/gulp/npm scripts.

@ZoeBijl ZoeBijl closed this as completed Jan 13, 2016
@karlgroves
Copy link

Definitely agree with starting small, but IMO you could/ should auto beautify to enforce your coding standards and require that all PRs pass the validity checks.

@ZoeBijl
Copy link
Author

ZoeBijl commented Jan 13, 2016

I agree, have filed an issue: #202

pkra pushed a commit that referenced this issue May 20, 2024
Closes #174
Closes #1887

add normative expectations and examples for computedrole
pkra pushed a commit that referenced this issue May 20, 2024
add doc-dedication to aside dpub allowances
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants