Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role parity for html:ins and html:del #526

Closed
cookiecrook opened this issue Feb 14, 2017 · 6 comments
Closed

Role parity for html:ins and html:del #526

cookiecrook opened this issue Feb 14, 2017 · 6 comments
Milestone

Comments

@cookiecrook
Copy link
Contributor

ins https://www.w3.org/TR/html51/edits.html#the-ins-element
del https://www.w3.org/TR/html51/edits.html#the-del-element

@aleventhal
Copy link
Contributor

Good names for this are probably role="insertion" and "deletion". Would use this with ARIA annotations. I'm planning to implement an experimental version of this behind a flag in Chrome, meaning that it's an experiment that users have to turn on in chrome://flags.

@LJWatson
Copy link
Contributor

LJWatson commented Feb 22, 2019 via email

@aleventhal
Copy link
Contributor

aleventhal commented Feb 22, 2019

@LJWatson it's not necessarily past tense. Sometimes it's a proposed insertion or deletion. The proposal is that can live inside a suggestion (future possible change) or revision (past change) container. The aria-details on the container points to an element that describes the type of annotation.

<span aria-details="suggestion-1">
  <span role="insertion">cat</span>
  <span role="deletion">dog</span>
</span>

where #suggestion-1 is something like:

<div role="annotation-suggestion">
Proposed change by Fru Fru Kittay
</div>

More info: https://github.com/w3c/aria/wiki/ARIA-annotations-draft-proposal

@asurkov
Copy link
Contributor

asurkov commented Apr 9, 2019

Good names for this are probably role="insertion" and "deletion". Would use this with ARIA annotations. I'm planning to implement an experimental version of this behind a flag in Chrome, meaning that it's an experiment that users have to turn on in chrome://flags.

I would probably stick with ins/del naming to stay closer to HTML, less chances to confuse when using both HTML/ARIA.

Btw, why ARIA needs these roles upfront? Do HTML:ins/del elements have restrictions that ARIA allows to bypass or it's just part of some bigger effort to make ARIA embrace all semantics of HTML?

@aleventhal
Copy link
Contributor

ARIAWG decided to go with the full name in order be consistent across ARIA with using full names. The only exception now is "img".

We need these roles as part of bigger effort to embrace semantics of HTML. Specifically, this allows an AOM tree to contain an insertion or deletion.

@cookiecrook
Copy link
Contributor Author

cookiecrook commented Apr 9, 2019

@aleventhal wrote:

The only exception now is "img".

…and that mistake will annoy—nay—haunt one of the former editors until the day he dies. 🙄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants