Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria-errormessage spec suggests aria-invalid state affects rendering of error element #796

Closed
AmeliaBR opened this issue Aug 2, 2018 · 1 comment · Fixed by #1098
Closed
Assignees
Labels
has PR PR exists that will close this issue
Milestone

Comments

@AmeliaBR
Copy link
Contributor

AmeliaBR commented Aug 2, 2018

During discussion on Twitter, the following passage from the aria-errormessage description caused some confusion:

When an object is in a valid state, it has either aria-invalid set to false or it does not have the aria-invalid attribute. If a valid object has aria-errormessage, the element referenced by aria-errormessage is not rendered because the message it contains is not pertinent.

The phrase "is not rendered" is ambiguous. To an author reading that paragraph, it makes it sound like the rendering change happens automatically.

However, the next paragraph puts the responsibility on the author to manage the rendering of the error message:

When aria-errormessage is pertinent, authors MUST ensure the content is not hidden so users can navigate to and examine the error message. Similarly, when aria-errormessage is not pertinent, authors MUST either ensure the content is not rendered or remove the aria-errormessage attribute or its value.

Suggested text to replace the former paragraph:

When an object is in a valid state, it has either aria-invalid set to false or it does not have the aria-invalid attribute. Authors MAY use an aria-errormessage attribute on an object that is currently valid, but only if the element referenced by aria-errormessage is not rendered, because the message it contains is not pertinent.

In addition, I wonder whether the phrase "is not rendered", in both paragraphs, should be replaced by "hidden", which has an explicit definition in the spec.

@mcking65 mcking65 added this to the ARIA 1.2 milestone Aug 8, 2018
@carmacleod
Copy link
Contributor

Or perhaps (slightly shorter):

If a valid object has aria-errormessage, authors MUST NOT render the element referenced by aria-errormessage because the message it contains is not pertinent.

Interesting that "rendered", which is used in a lot of places in the spec, doesn't have an explicit definition. Should it? It is used in the context of AT making strings available as speech/braille, as well as either authors or user agents making something visible or "not hidden". Possibly other contexts, too. Would be a complicated definition. :)

@jnurthen jnurthen assigned scottaohara and unassigned mcking65 Oct 14, 2019
scottaohara added a commit that referenced this issue Oct 15, 2019
closes #796 by updating the text per recommendation in the issue.

change wording from “not rendered” to hidden, and link to hidden’s definition.  This creates consistency with other parts of the `aria-errormessage`’s description where the term “hidden” is already used.
@scottaohara scottaohara added the has PR PR exists that will close this issue label Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has PR PR exists that will close this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants