Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

term/definition should use aria-details instead of aria-labelledby #1147

Merged
merged 14 commits into from
Dec 16, 2020
Merged

term/definition should use aria-details instead of aria-labelledby #1147

merged 14 commits into from
Dec 16, 2020

Commits on Jan 7, 2020

  1. term/defnition should use aria-details instead of aria-labelledby

    @aleventhal
    aleventhal committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    1712d04 View commit details
    Browse the repository at this point in the history

  2. Name is prohibited on a term

    @aleventhal
    aleventhal committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    7779757 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2020

  1. Improved readability, remove problematic descendant approach

    @aleventhal
    aleventhal committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    76ebae3 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2020

  1. Use capitlized SHOULDs

    @aleventhal
    aleventhal committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    dd33293 View commit details
    Browse the repository at this point in the history

  2. remove extra end paragraph tag

    @scottaohara
    scottaohara committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    a97a587 View commit details
    Browse the repository at this point in the history

  3. Update index.html 

    Co-Authored-By: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com>
    @aleventhal @carmacleod
    aleventhal and carmacleod committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    912ff71 View commit details
    Browse the repository at this point in the history

  4. Prohibit name on a definition, require that a definition MUST have a … 

    …term, require that a term with a matching definition MUST use aria-details to point to it
    @aleventhal
    aleventhal committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    cd8b0aa View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2020

  1. Suggested change to alleviate confusion where there is no definition,… 

    … that should provide a good screen reader experience in that case.
    @aleventhal
    aleventhal committed Jan 11, 2020
    Configuration menu
    Copy the full SHA
    8179992 View commit details
    Browse the repository at this point in the history

  2. fix typo

    @scottaohara
    scottaohara committed Jan 11, 2020
    Configuration menu
    Copy the full SHA
    caa653c View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2020

  1. Fix typos and sentence grammar

    @aleventhal
    aleventhal committed Jan 12, 2020
    Configuration menu
    Copy the full SHA
    2aa6add View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2020

  1. Merge branch 'term_def_details' of github.com:w3c/aria into term_def_… 

    …details
    @aleventhal
    aleventhal committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    b14eea3 View commit details
    Browse the repository at this point in the history

  2. Try again

    @aleventhal
    aleventhal committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    23ed124 View commit details
    Browse the repository at this point in the history

  3. Clean up wording, add semantic sugar

    @aleventhal
    aleventhal committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    84c66d9 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2020

  1. fix spacing

    @jnurthen
    jnurthen committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    6187596 View commit details
    Browse the repository at this point in the history