Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a conditional on when aria-controls is needed #1335

Merged
merged 2 commits into from Dec 16, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 3 additions & 5 deletions index.html
Expand Up @@ -2113,7 +2113,7 @@ <h2>Definition of Roles</h2>
</p>
<p>
Authors MUST ensure the popup element associated with a <code>combobox</code> has a role of <rref>listbox</rref>, <rref>tree</rref>, <rref>grid</rref>, or <rref>dialog</rref>.
Authors MUST set <pref>aria-controls</pref> on a <code>combobox</code> element to a value that refers to the <code>combobox</code> popup element.
When the popup is displayed, authors MUST set <pref>aria-controls</pref> on a <code>combobox</code> element to a value that refers to the <code>combobox</code> popup element.
</p>
<p>
Elements with the role <code>combobox</code> have an implicit <pref>aria-haspopup</pref> value of <code>listbox</code>.
Expand Down Expand Up @@ -2200,10 +2200,7 @@ <h2>Definition of Roles</h2>
<tr>
<th class="role-required-properties-head">Required States and Properties:</th>
<td class="role-required-properties">
<ul>
<li><pref>aria-controls</pref></li>
<li><sref>aria-expanded</sref></li>
</ul>
<sref>aria-expanded</sref>
</td>
</tr>
<tr>
Expand All @@ -2212,6 +2209,7 @@ <h2>Definition of Roles</h2>
<ul>
<li><pref>aria-activedescendant</pref></li>
<li><pref>aria-autocomplete</pref></li>
<li><pref>aria-controls</pref></li>
<li><pref>aria-errormessage</pref></li>
<li><pref>aria-haspopup</pref></li>
<li><sref>aria-invalid</sref></li>
Expand Down