Skip to content

Add a conditional on when aria-controls is needed #1335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jnurthen merged 2 commits into from
Dec 16, 2020
Merged

Add a conditional on when aria-controls is needed #1335

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b709902
Add a conditional on when aria-controls is needed
jnurthen Oct 7, 2020
eef2e15
move aria-controls from required to supported
jnurthen Nov 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2113,7 +2113,7 @@ <h2>Definition of Roles</h2>
</p>
<p>
Authors MUST ensure the popup element associated with a <code>combobox</code> has a role of <rref>listbox</rref>, <rref>tree</rref>, <rref>grid</rref>, or <rref>dialog</rref>.
Authors MUST set <pref>aria-controls</pref> on a <code>combobox</code> element to a value that refers to the <code>combobox</code> popup element.
When the popup is displayed, authors MUST set <pref>aria-controls</pref> on a <code>combobox</code> element to a value that refers to the <code>combobox</code> popup element.
</p>
<p>
Elements with the role <code>combobox</code> have an implicit <pref>aria-haspopup</pref> value of <code>listbox</code>.
Expand Down Expand Up @@ -2200,10 +2200,7 @@ <h2>Definition of Roles</h2>
<tr>
<th class="role-required-properties-head">Required States and Properties:</th>
<td class="role-required-properties">
<ul>
<li><pref>aria-controls</pref></li>
<li><sref>aria-expanded</sref></li>
</ul>
<sref>aria-expanded</sref>
</td>
</tr>
<tr>
Expand All @@ -2212,6 +2209,7 @@ <h2>Definition of Roles</h2>
<ul>
<li><pref>aria-activedescendant</pref></li>
<li><pref>aria-autocomplete</pref></li>
<li><pref>aria-controls</pref></li>
<li><pref>aria-errormessage</pref></li>
<li><pref>aria-haspopup</pref></li>
<li><sref>aria-invalid</sref></li>
Expand Down