Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editorial: role time placeholder "inherited" #2092

Merged
merged 1 commit into from
Jan 3, 2024
Merged

editorial: role time placeholder "inherited" #2092

merged 1 commit into from
Jan 3, 2024

Conversation

pkra
Copy link
Member

@pkra pkra commented Dec 14, 2023

Adds missing placeholder text which aria.js hooks into to populate this table cell.

Closes #2089


Preview | Diff

Adds missing placeholder text (which aria.js hooks into to populate this table cell).

Closes #2089
@pkra pkra added the editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo label Dec 14, 2023
@pkra
Copy link
Member Author

pkra commented Dec 14, 2023

Huh. This is weird. The spec hasn't actually changed.

@pkra pkra self-assigned this Dec 14, 2023
@jnurthen
Copy link
Member

jnurthen commented Jan 3, 2024

Yeah - looking at the code it seems placeholder text isn't necessary for the inherited states and properties section. We should probably have it there for consistency though.

@pkra pkra merged commit a0f796f into main Jan 3, 2024
4 checks passed
@pkra pkra deleted the issue2089 branch January 3, 2024 20:36
github-actions bot added a commit that referenced this pull request Jan 3, 2024
SHA: a0f796f
Reason: push, by pkra

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is the role=time markup for inherited states and properties intentional?
2 participants