monorepo: add core-aam history #2184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pkra
commented
May 20, 2024
•
pkra
commented
- add core-aam history
- remove extraneous files
- adjust links to aria-common
…rkType (#639) This is redundant and not required for implementers. Localized {Landmark, Control} Types are supposed to provide additional information; not duplicate the same information available in {Landmark, Control} Type.
Makes editing easier and will also help when programmatically generating testable statements.
When aria-sort is used on a columnheader, it does not change the platform role; aria-sort is mapped to NSAccessibilitySortDirectionAttribute.
These will be needed by some not-yet-committed tools to generate testable statements automatically.
Write mappings in a consistent format, both for readability and for easier programmatic generation of testable statements
Also fix typo in markup.
Should be AXToggle; not AXToggleButton
…a-owns This change reflects what is seen in (at least) Gecko, but leaves the possibility of continuing to use the accessible relation types which were previously used by Gecko and may still be used by other user agents.
This is not a change; merely a clarification.
These notations were in place to ensure changes we must test as part of the CR process were not missed. These changes are now all noted in the testable statements wiki for Core AAM. Also addresses github issue #645.
… in Core-AAM (#647) Clarify the criteria for elements with children presentational true to specify that: 1. Text content of excluded elements is included 2. Exceptions, such as focusability, also apply This is already stated in the ARIA specification, but was not clear from the text present in the Core AAM. Fixes github issue #492.
mostly by converting to regular note
* Fix aria-readonly UIA mappings * Unconditionally expose readonly in UIA AriaProperties to match docs
Co-authored-by: Rahim Abdi <rahim_abdi@apple.com>
Drops the previously active section and adds a new GH contributors section, matching other ARIA specs. See w3c/aria-common#103 for more background.
* Editorial: Remove reference to no longer existing term (owned) * Language recommendation from smhigley
✅ Deploy Preview for ephemeral-daifuku-0dc7d7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Adds: - .prettierignore: ignore ARIA spec index.html - .github/workflows/dependabot.yaml: check for updates - .github/workflows/prettier.yaml: run prettier on */index.html (except what is specified in .prettierignore)
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I've cherry-picked the prettier setup from the monorepo branch (cf. #2197) |
|
Prettier fails but due to invalid markup in the spec. |
|
I've removed the stray closing cite tag - prettier CI now ran as desired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.