Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core-aam] Rules for excluding elements from the accessibility tree confuse definition of presentational elements #492

Closed
mcking65 opened this issue Dec 2, 2016 · 5 comments
Labels
editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo

Comments

@mcking65
Copy link
Contributor

mcking65 commented Dec 2, 2016

Section 5.1.1 Excluding Elements from the Accessibility Tree
does not distinguish between hiding an element and hiding an element and its content.

While the first rule references the definition of the presentation role, it still states that the element is not exposed using the same language as the second rule for hidden content. That is, the rules seem to equate the treatment of presentational elements with the treatment of hidden elements.

Similarly, the description of user agent treatment for aria-hidden does not have any clear differences from the description of user agent treatment of elements that have children presentational true.

@mcking65 mcking65 added AAM editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo labels Dec 2, 2016
@joanmarie
Copy link
Contributor

Text designed to clarify issues related to presentational elements has been added to the ARIA spec and referenced in Section 5.1.1 of the Core AAM. In particular, the first rule/item now has the following content related to presentation-role elements:

However, their exclusion is conditional and depends on other factors. In addition, the element's descendants and text content are generally included. These exceptions and conditions are documented in the section "Presentational Roles Conflict Resolution" in Accessible Rich Internet Applications (WAI-ARIA) 1.1.

@mcking65: Does the above content from the Core AAM, combined with the new "Presentation Roles Conflict Resolution" content which was added to the ARIA spec, solve the confusion you reported?

@mcking65
Copy link
Contributor Author

mcking65 commented Sep 14, 2017

It is closer for role presentation, but not for children presentational.

For role presentation, the added text, with some editorial improvement, could resolve this issue.

In particular, the "Presentational Roles Conflict Resolution" subsection in ARIA needs some editorial work to correct grammar errors and make it understandable.

For instance, missing " of " in:

There are a number ways presentational role conflicts are resolved.

And this paragraph needs a rewrite to make it intelligible:

Host languages elements, having implicit presentational roles for which no roles, may be applied, must never be exposed to in the accessibility tree. With this exception, user agents must always expose global WAI-ARIA states and properties to accessibility APIs. In this case, the user agent ignores the presentation role and exposes the element according to its implicit native semantics. However, user agents must ignore any non-global, role-specific WAI-ARIA states and properties, unless it is on an inherited presentational role where an explicit role is applied.

The only way I came to understand it was because of the subsequent example.

WRT children presentational, core AAM is still written as if children presentational true is the same as aria-hidden true. It does not say that the text nodes of elements with children presentational true are included in the accessibility tree.

@joanmarie
Copy link
Contributor

So it sounds like we have two separate issues: 1) Editorial improvement is needed to the ARIA spec. 2) What you subsequently state about the Core AAM, namely:

WRT children presentational, core AAM is still written as if children presentational true is the same as aria-hidden true. It does not say that the text nodes of elements with children presentational true are included in the accessibility tree.

With respect to the latter, could you provide a pull request which adds the language you would like to see so that we can close this issue? Thanks in advance!

@joanmarie
Copy link
Contributor

Regarding the editorial improvement needed to the ARIA spec, I've created issue #646. (I've fixed the missing "of" already. This issue is now strictly about the Core AAM.

mcking65 added a commit that referenced this issue Sep 15, 2017
…onal Elements

For issue #492, modified section "5.1.1 Excluding Elements from the Accessibility Tree" in core-aam.html.

Clarified the criteria for elements with children presentational true to specify that:
1. Text content of excluded elements is included and;
2. Exceptions, such as focusability, also apply.
joanmarie pushed a commit that referenced this issue Sep 15, 2017
… in Core-AAM (#647)

Clarify the criteria for elements with children presentational true to specify that:
1. Text content of excluded elements is included
2. Exceptions, such as focusability, also apply

This is already stated in the ARIA specification, but was not clear from
the text present in the Core AAM.

Fixes github issue #492.
@joanmarie
Copy link
Contributor

The clarifying text from @mcking65 have been merged. Closing as FIXED.

pkra pushed a commit that referenced this issue May 20, 2024
… in Core-AAM (#647)

Clarify the criteria for elements with children presentational true to specify that:
1. Text content of excluded elements is included
2. Exceptions, such as focusability, also apply

This is already stated in the ARIA specification, but was not clear from
the text present in the Core AAM.

Fixes github issue #492.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo
Projects
None yet
Development

No branches or pull requests

3 participants