[accname PR 236] Renaming LabelledBy Recursion since it's not recursive. #2207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
pkra
changed the title
MelSumner
approved these changes
Jul 8, 2024
accdc
approved these changes
Jul 8, 2024
smhigley
approved these changes
Jul 8, 2024
| If traversal of the <code>current node</code> is due to recursion <strong>and</strong> the <code>current node</code> is an embedded control, ignore <code>aria-label</code> and | ||
| skip to rule <a href="#comp_embedded_control">Embedded Control</a>. | ||
| If traversal of the <code>current node</code> is due to <a href="#comp_name_from_content_for_each_child">Name From Content descendant node recursion</a> <strong>and</strong> the | ||
| <code>current node</code> is an embedded control, ignore <code>aria-label</code> and skip to rule <a href="#comp_embedded_control">Embedded Control</a>. |
There was a problem hiding this comment.
This issue wasn't introduced in this PR, but it appears that Embedded Control actually precedes this step and will be processed first, so this check seems unnecessary and could maybe be removed entirely. I'm guessing that in the past, that wasn't the case 😅.
I don't think this PR should be held up by this, but maybe it's something to fix later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved from w3c/accname#236
Closes accname issue 222
Renaming "LabelledBy Recursion" to "LabelledBy Traversal" since this step is not actually recursive.