Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[accname PR 236] Renaming LabelledBy Recursion since it's not recursive. #2207

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[accname PR 236] Renaming LabelledBy Recursion since it's not recursive. #2207

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
826d86c
Renaming LabelledBy Recursion since it's not recursive.
cookiecrook May 1, 2024
8fdd9ce
editorial: move accname PR236
pkra May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions accname/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,8 +513,8 @@ <h4>Computation steps</h4>
<li id="comp_labelledby_set_current">
<span id="step2B.ii.a"><!-- Don't link to this legacy numbered ID. --></span>Set the <code>current node</code> to the node referenced by the IDREF.
</li>
<li id="comp_labelledby_recursion">
<span id="step2B.ii.b"><!-- Don't link to this legacy numbered ID. --></span><em>LabelledBy Recursion:</em> Compute the text alternative of the
<li id="comp_labelledby_traversal">
<span id="step2B.ii.b"><!-- Don't link to this legacy numbered ID. --></span><em>LabelledBy Traversal:</em> Compute the text alternative of the
<code>current node</code> beginning with the overall <a href="#comp_computation">Computation</a> step. Set the <code>result</code> to that text alternative.
</li>
<li id="comp_labelledby_append">
Expand All @@ -528,7 +528,7 @@ <h4>Computation steps</h4>
</ol>
<div>
<p>
The result of <a href="#comp_labelledby_recursion">LabelledBy Recursion</a> in combination with <a href="#comp_hidden_not_referenced">Hidden Not Referenced</a> means that
The result of <a href="#comp_labelledby_traversal">LabelledBy Traversal</a> in combination with <a href="#comp_hidden_not_referenced">Hidden Not Referenced</a> means that
<a class="termref">user agents</a> MUST include all nodes in the subtree as part of the <a class="termref">accessible name</a> or <a class="termref">accessible description</a>,
when the node referenced by <code>aria-labelledby</code> or <code>aria-describedby</code> is hidden.
</p>
Expand Down Expand Up @@ -589,8 +589,8 @@ <h4>Computation steps</h4>
whose value is not undefined, not the empty string, nor, when trimmed of [=ascii whitespace|whitespace=], is not the empty string:
<ol>
<li>
If traversal of the <code>current node</code> is due to recursion <strong>and</strong> the <code>current node</code> is an embedded control, ignore <code>aria-label</code> and
skip to rule <a href="#comp_embedded_control">Embedded Control</a>.
If traversal of the <code>current node</code> is due to <a href="#comp_name_from_content_for_each_child">Name From Content descendant node recursion</a> <strong>and</strong> the
<code>current node</code> is an embedded control, ignore <code>aria-label</code> and skip to rule <a href="#comp_embedded_control">Embedded Control</a>.
Copy link
Contributor

@smhigley smhigley Jul 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue wasn't introduced in this PR, but it appears that Embedded Control actually precedes this step and will be processed first, so this check seems unnecessary and could maybe be removed entirely. I'm guessing that in the past, that wasn't the case 😅.

I don't think this PR should be held up by this, but maybe it's something to fix later.

</li>
<li>Otherwise, return the value of <code>aria-label</code>.</li>
</ol>
Expand Down
Loading