Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[html-aam] - UIA input mappings cleanup #2275

Merged
merged 2 commits into from
Aug 15, 2024
Merged

[html-aam] - UIA input mappings cleanup #2275

merged 2 commits into from
Aug 15, 2024

Conversation

scottaohara
Copy link
Member

@scottaohara scottaohara commented Jul 12, 2024

closes #173

the localized control types for the UIA mappings for various input elements is not how these controls are actually reflected... nor, per the issue filed, how they likely should be.

being 'edit' fields with accNames that will more than likely convey their purpose is likely enough, and the localized control types don't need to reflect the type attribute value.

This is not a normative change, since this updates the spec to reflect the current implementation.

Additional inputs may need to be reviewed / changed, but those can be updated in a separate PR.

closes #173

the localized control types for the UIA mappings for various input elements is not how these controls are actually reflected... nor, per the issue filed, how they likely should be.

being 'edit' fields with accNames that will more than likely convey their purpose is likely enough, and the localized control types don't need to reflect the type attribute value.

This is not a normative change, since this updates the spec to reflect the current implementation.

Additional inputs may need to be reviewed / changed, but those can be updated in a separate PR.
Copy link

netlify bot commented Jul 12, 2024

Deploy Preview for wai-aria ready!

Name Link
🔨 Latest commit 8c3fc86
🔍 Latest deploy log https://app.netlify.com/sites/wai-aria/deploys/669197599a40b60008945f00
😎 Deploy Preview https://deploy-preview-2275--wai-aria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jnurthen jnurthen requested a review from benbeaudry July 18, 2024 17:20
Copy link
Contributor

@benbeaudry benbeaudry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double checked that Chromium wasn't setting any of those localized control type mapping. LGTM.

@scottaohara scottaohara merged commit 6723ad2 into main Aug 15, 2024
5 checks passed
@scottaohara scottaohara deleted the uia-input-cleanup branch August 15, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"e-mail" is incorrect localized control type
2 participants