Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Make specURLs consistent and fix some respec warnings #2305

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

daniel-montalvo
Copy link
Contributor

@daniel-montalvo daniel-montalvo commented Aug 6, 2024

Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for wai-aria ready!

Name Link
🔨 Latest commit 4bc3b80
🔍 Latest deploy log https://app.netlify.com/sites/wai-aria/deploys/66c47f2aaba8100008ac3f8e
😎 Deploy Preview https://deploy-preview-2305--wai-aria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for one minor nit, I think a change got snuck in here which also is in #2288

@@ -16676,7 +16710,7 @@ <h3>Acknowledgments</h3>
Add listing of individuals who have providing meaningful
contributions through commenting that have impacted the specification.
--></div>
<div data-include="https://rawgit.com/w3c/aria/master/../common/acknowledgements/funders.html" data-include-replace="true"></div>
<div data-include="../common/acknowledgements/funders.html" data-include-replace="true"></div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to approve but I accidentally commented -- the only thing is: #2305 (comment)

@spectranaut spectranaut changed the title [Editorial] Make specURLs consistent and fix some respec warnings Editorial: Make specURLs consistent and fix some respec warnings Aug 19, 2024
@daniel-montalvo
Copy link
Contributor Author

Hi @spectranaut

        <div data-include="https://rawgit.com/w3c/aria/master/../common/acknowledgements/funders.html" data-include-replace="true"></div>

I think we should replace it with common/acknowledgements/funders.html, not sure why it's using the absolute path here, plus it throws a 404, at least when running respec on the browser.

I've replaced it here, left https://github.com/w3c/aria/pull/2288/files#diff-5c3c8936e81538898c83ae11f5271e9ae9324925713a3b03aca58cbd2a3c3014 intact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants