[Core AAM] Update AXRoleDescription mappings for alertdialog and dialog #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* AXRoleDescription for alertdialog is now "web alert dialog" * AXRoleDescription for dialog is now "web dialog" Fixes github issue #535
|
@klown This change still needs a ChangeLog entry. I can add it now, but then there will likely be a merge conflict if PR 537 is pulled in first. Lemme know how you'd like to proceed. Thanks! |
|
@joanmarie -- thanks! I added the changelog myself (you've got enough to do), and applied your changes. If you think this is complete, feel free to close the issue. Change for alertdialog: Change for dialog: Changelog: |
|
Closing, based on decision at AAPI meeting 21-Mar-2017. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes github issue #535