Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revised link example with template #89

Merged
merged 3 commits into from
Sep 21, 2015
Merged

revised link example with template #89

merged 3 commits into from
Sep 21, 2015

Conversation

a11ydoer
Copy link
Contributor

Template has 4 sections : 1)Examples, 2)keyboard support, 3)ARIA Roles,
Properties and States, and 4)Source code

JemmaJaeunKu and others added 3 commits September 14, 2015 16:45
Template has 4 sections : 1)Examples, 2)keyboard support, 3)ARIA Roles,
Properties and States, and 4)Source code
edit source code option in button.html
added another example css content in link.html
@ZoeBijl
Copy link

ZoeBijl commented Sep 17, 2015

This all looks very good, but why is there a role="banner" on the <header>, that is an implied role; no need for it right?

mcking65 added a commit that referenced this pull request Sep 21, 2015
revised link example with template
@mcking65 mcking65 merged commit ab57763 into w3c:master Sep 21, 2015
@mcking65
Copy link
Contributor

Putting role banner on header will still work in browser versions that do not support the HTML 5 mapping.

@stevefaulkner
Copy link
Contributor

@ZoeBijl
Copy link

ZoeBijl commented Sep 21, 2015

It is my understanding that these examples should focus on conformance and not so much legacy support.

@mcking65
Copy link
Contributor

Best practice in conformance, yes. My understanding is that it is still considered best practice to not fully rely on the HTML 5 mapping of landmark regions by adding the landmark role to html5 elements. I guess we should learn more about compatibility and support to be clear on this. For example, I think browsers only started supporting the main element last year.

We have agreed that we do not want our examples to perform gymnastics to support very old browsers, e.g., IE8 and 9 … that was my understanding of legacy support.

@ZoeBijl
Copy link

ZoeBijl commented Sep 21, 2015

I agree. It seems IE11 doesn't support either footer, header, or main: http://html5accessibility.com/. Support in the Edge browser is unknown at this point.

I'm all for adding support for current browsers as long as it's not through proprietary code.

I'm working on a list of things to take into account when one works on the examples. Shall I add this to the list?

“It's okay to add support for current browsers as long as that support can be added with conforming code. You can check both html5accessibilit.com and caniuse.com for support tables.”

@stevefaulkner
Copy link
Contributor

@MichielBijl my comment on an article about aria redundancy http://www.sitepoint.com/avoiding-redundancy-wai-aria-html-pages/#comment-2258207796 may be helpful

@ZoeBijl
Copy link

ZoeBijl commented Sep 21, 2015

What I take away from that is that we should look at AT support rather than browser support, is that correct?

—Michiel

On 21 Sep 2015, at 09:16, stevefaulkner notifications@github.com wrote:

@MichielBijl my comment here http://www.sitepoint.com/avoiding-redundancy-wai-aria-html-pages/#comment-2258207796 may be helpful


Reply to this email directly or view it on GitHub.

@stevefaulkner
Copy link
Contributor

@MichielBijl if it's interoperably implemented in browsers that is enough me thinks

@ZoeBijl
Copy link

ZoeBijl commented Sep 21, 2015

Cool. Do we have any sources for this?

@stevefaulkner
Copy link
Contributor

@MichielBijl sources for?

@mcking65
Copy link
Contributor

if it's interoperably implemented in browsers that is enough me thinks

Previous example was IE11 does not interoperably implement header, footer, and main. So, should we consider it a best practice to add redundant ARIA roles? Or, should we look at how many AT implement support based on their own DOM parsing before deciding to recommend adding extra code to compensate for a browser deficiency?

@ZoeBijl
Copy link

ZoeBijl commented Sep 21, 2015

@stevefaulkner to decide what to include / which browsers to support. I don't know wether to include role's or not; I don't have any data to base my decision on.

pkra pushed a commit that referenced this pull request May 20, 2024
AX API: Complete mapping for 'time' element (Github issue #88)
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants