Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some properties from "required" to "supported" on scrollbar role #944

Merged
merged 4 commits into from Jun 4, 2019

Conversation

melanierichards
Copy link
Contributor

@melanierichards melanierichards commented Apr 11, 2019

Addresses #858


Preview | Diff

@jnurthen
Copy link
Member

link for review

@carmacleod
Copy link
Contributor

This sentence:

Authors MUST set the aria-valuemin, aria-valuemax, and aria-valuenow attributes.

should probably just be:

Authors MUST set the value of the aria-valuenow attribute.

The list that follows the above sentence may need rewording as well:

If missing, their implicit values follow the same rules as the HTML range input type:

  • If aria-valuemin is missing or not a number, it defaults to 0 (zero).
  • If aria-valuemax is missing or not a number, it defaults to 100.
  • If aria-valuenow is missing or not a number, it defaults to the value half way between aria-valuemin and aria-valuemax.
  • If aria-valuenow is present but less than aria-valuemin, it defaults to the value of aria-valuemin.
  • If aria-valuenow is present but greater than aria-valuemax, it defaults to the value of aria-valuemax.

@melanierichards
Copy link
Contributor Author

Methinks I was a little too literal in addressing the issues for these and missed some prose update opportunities, thanks @carmacleod for all your feedback! :)

Made some changes to the prose, left repair techniques in there for now because Core-AAM doesn't seem to cover the overflow repair techniques (where valuenow is less than valuemin, for example). I imagine this may warrant further discussion, especially given that, from a quick test, the Windows browsers aren't following these repair techniques: https://jsfiddle.net/r39sqne2/2/

index.html Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@melanierichards
Copy link
Contributor Author

Should be up to date now based on 2019-05-23 call.

@joanmarie joanmarie merged commit 9380b65 into w3c:master Jun 4, 2019
joanmarie pushed a commit that referenced this pull request Jun 4, 2019
…#944)

Addresses #858

* Update scrollbar role prose to better reflect properties moving from 'required' to 'supported'
* Scrollbar role: remove aria-valuenow repair techniques to the fallback table and point to said table
* Remove supported but not required attrs on scrollbar from the author error handling table
carmacleod pushed a commit that referenced this pull request Oct 17, 2019
…#944)

Addresses #858

* Update scrollbar role prose to better reflect properties moving from 'required' to 'supported'
* Scrollbar role: remove aria-valuenow repair techniques to the fallback table and point to said table
* Remove supported but not required attrs on scrollbar from the author error handling table
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants