Move some properties from "required" to "supported" on slider role #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melanierichards
force-pushed
the
slider-defaults
branch
from
1b5688d
to
d067b5d
Compare
|
Change:
to:
|
|
Also, the list that follows that sentence need to be reworded:
Maybe delete the valuenow bullet? |
…now supported, not required
|
Addressed this one similarly to #944, so probably the discussion will be pretty similar. Likewise, quick check at Win browsers suggest implementations don't follow the repair techniques for |
mcking65
requested changes
Apr 27, 2019
melanierichards
force-pushed
the
slider-defaults
branch
from
c3934ee
to
c40c3f8
Compare
…or handling table
|
Feedback from 2019-05-23 call should be addressed. |
joanmarie
pushed a commit
that referenced
this pull request
Jun 4, 2019
) Addresses #860 * Reword slider role prose to reflect that aria-valuemin, valuemax are now supported, not required * Remove aria-valuenow repair techniques from inline in the slider role * Make fallback table more robust for aria-valuenow on slider role * Add pointer to the fallback table from slider role * Remove supported but not required attrs on slider from the author error handling table
carmacleod
pushed a commit
that referenced
this pull request
Oct 17, 2019
) Addresses #860 * Reword slider role prose to reflect that aria-valuemin, valuemax are now supported, not required * Remove aria-valuenow repair techniques from inline in the slider role * Make fallback table more robust for aria-valuenow on slider role * Add pointer to the fallback table from slider role * Remove supported but not required attrs on slider from the author error handling table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #860
Preview | Diff